Update patch set 2
Patch Set 2: Code-Review-1 (2 comments) small concerns but lgtm Patch-set: 2 Reviewer: Gerrit User 7075 <7075@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
3ef512c7d3
commit
d83e826259
|
@ -0,0 +1,44 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df140735_9003e1b8",
|
||||
"filename": "deployment_scripts/puppet/modules/telemetry/files/common/samples.lua",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 188,
|
||||
"author": {
|
||||
"id": 7075
|
||||
},
|
||||
"writtenOn": "2017-06-01T08:05:52Z",
|
||||
"side": 1,
|
||||
"message": "move this line after the if block",
|
||||
"range": {
|
||||
"startLine": 188,
|
||||
"startChar": 0,
|
||||
"endLine": 188,
|
||||
"endChar": 28
|
||||
},
|
||||
"revId": "22f10ada61d866459d1e189b236b84966af2b13c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df140735_10291137",
|
||||
"filename": "deployment_scripts/puppet/modules/telemetry/files/common/samples.lua",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 190,
|
||||
"author": {
|
||||
"id": 7075
|
||||
},
|
||||
"writtenOn": "2017-06-01T08:05:52Z",
|
||||
"side": 1,
|
||||
"message": "please use space for indentation",
|
||||
"revId": "22f10ada61d866459d1e189b236b84966af2b13c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue