x
/
gearman-plugin
Code Issues Proposed changes

switch out logger binding and remove unused file 

LabelAssignmentActionImpl.java - removed because it's been replaced by NodeAssignmentAction
pom.xml - switched out SimpleLogger with logback binding
logback.xml - the logback logging configurations.

Change-Id: I17e995df2f5f851051212369bafbfdca65558e98
This commit is contained in:
Khai Do 2013-02-01 15:14:47 -08:00
parent 7f4fee3e45
commit 6f8a75cd61
3 changed files with 37 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
pom.xml
View File

@ -134,6 +134,10 @@
<taglist-maven-plugin.version>2.4</taglist-maven-plugin.version>
<versions-maven-plugin.version>1.2</versions-maven-plugin.version>
<xml-maven-plugin.version>1.0-beta-3</xml-maven-plugin.version>
<slf4j.version>1.7.2</slf4j.version>
<logback.version>1.0.9</logback.version>
<gson.version>2.2.2</gson.version>
<gearman.version>0.6-SNAPSHOT</gearman.version>
</properties>
<build>
@ -331,22 +335,32 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.6.1</version>
<version>${slf4j.version}</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
<version>1.7.2</version>
<version>${slf4j.version}</version>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>${logback.version}</version>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<version>${logback.version}</version>
</dependency>
<dependency>
<groupId>org.gearman</groupId>
<artifactId>gearman-java</artifactId>
<version>0.6-SNAPSHOT</version>
<version>${gearman.version}</version>
</dependency>
<dependency>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
<version>2.2.2</version>
<version>${gson.version}</version>
</dependency>
</dependencies>
</project>

59
src/main/java/hudson/plugins/gearman/LabelAssignmentActionImpl.java
View File

@ -1,59 +0,0 @@
/*
*
* Copyright 2013 Hewlett-Packard Development Company, L.P.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
package hudson.plugins.gearman;
import hudson.model.Label;
import hudson.model.labels.LabelAssignmentAction;
import hudson.model.labels.LabelAtom;
import hudson.model.queue.SubTask;
public class LabelAssignmentActionImpl implements LabelAssignmentAction{
LabelAtom labelAtom;
public LabelAssignmentActionImpl(String label){
this.labelAtom = new LabelAtom(label);
}
@Override
public String getIconFileName(){
// TODO Auto-generated method stub
return null;
}
@Override
public String getDisplayName(){
// TODO Auto-generated method stub
return null;
}
@Override
public String getUrlName(){
// TODO Auto-generated method stub
return null;
}
@Override
public Label getAssignedLabel(SubTask task){
// TODO Auto-generated method stub
return labelAtom;
}
}

19
src/main/resources/logback.xml Normal file
View File

@ -0,0 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?>
<configuration>
<appender name="fileAppender" class="ch.qos.logback.core.FileAppender">
<file>GearmanPlugin.log</file>
<append>true</append>
<encoder>
<pattern>%d [%thread] %-5level %logger{35} - %msg%n</pattern>
</encoder>
</appender>
<appender name="consoleAppender" class="ch.qos.logback.core.ConsoleAppender">
<encoder>
<pattern>%d [%thread] %-5level %logger{35} - %msg%n</pattern>
</encoder>
</appender>
<root level="TRACE">
<appender-ref ref="fileAppender" />
<appender-ref ref="consoleAppender" />
</root>
</configuration>