Update patch set 2
Patch Set 2: Code-Review-1 (1 comment) Patch-set: 2 Label: Code-Review=-1
This commit is contained in:
parent
f7a34cf31c
commit
81382bd26a
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a890539_15eea1b4",
|
||||
"filename": "README.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 36,
|
||||
"author": {
|
||||
"id": 6609
|
||||
},
|
||||
"writtenOn": "2014-11-12T19:06:04Z",
|
||||
"side": 1,
|
||||
"message": "Just one thing here (which we should document) - this is the correct link for *cloning* but when people see an https address they expect to be able to open it in a browser, which is not the case with this address because it lacks the /cgit portion of the URL and ends in .git.\n\nTo clear up confusion in documentation, I recommend instead sharing the git:// url\n\ngit://git.openstack.org/openstack-infra/gearman-plugin.git\n\nOr instead of saying \"Cloning\" we could say \"Code repository\" or something and use the cgit url\n\nhttps://git.openstack.org/cgit/openstack-infra/gearman-plugin",
|
||||
"revId": "a5e61f2f9954f43f62df8f7ffa2444fd292756e7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue