x
/
gearman-plugin
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review+2

(2 comments)

Patch-set: 5
Reviewer: Gerrit User 2 <2@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
This commit is contained in:
Gerrit User 2 2015-05-06 13:18:04 +00:00 committed by Gerrit Code Review
parent 2bd5899769
commit 8e7229f2fe
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
65a08e0e959b0853538eabeec030d594a01c4385 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "1aca2d91_1aeea722",
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
"patchSetId": 5
},
"lineNbr": 188,
"author": {
"id": 2
},
"writtenOn": "2015-05-06T13:18:04Z",
"side": 1,
"message": "This is replacing the existing threadsafe linked queue with a different one, rather than clearing the original one. Does that break the threadsafe thing you\u0027re doing because the mutex would be associated with the old object and the new object would have a new mutex?",
"revId": "65a08e0e959b0853538eabeec030d594a01c4385",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_3a2cc349",
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
"patchSetId": 5
},
"lineNbr": 270,
"author": {
"id": 2
},
"writtenOn": "2015-05-06T13:18:04Z",
"side": 1,
"message": "wow that seems like duplication of the code just above. Just saying.",
"revId": "65a08e0e959b0853538eabeec030d594a01c4385",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}