x
/
gearman-plugin
Code Issues Proposed changes

Update patch set 10 

Patch Set 10: Code-Review-1

I ran another test with this patch.  My Jenkins is setup with 1 master and 2 slaves (linux-slave1 & linux-slave2) to run jobs.  I ran my 'simple' job on each.  Results from the slaves look good, however it looks like Jenkins applies a default 'master' label ("node_labels":["master","sun"]) but it doesn't have a node name ("node_name":""). Probably a Jenkins bug here.  So I'm not sure if we should handle this on the client side or just assign node_name to 'master' if it's blank?

------- test run ----- 

(py27)ubuntu@pygear-server:~/gearman-plugin-client$ python gear_client.py -s localhost --function=build:simple --iterations=3

Wed Aug 26 17:26:15 2015
Sending job: build:simple to localhost with params={'OFFLINE_NODE_WHEN_COMPLETE': 'false', 'uuid': '98de47931e9548a6b92ed2dfede4b676'}
Sending job: build:simple to localhost with params={'OFFLINE_NODE_WHEN_COMPLETE': 'false', 'uuid': '67c03612bd844cbe90ece7449855c398'}
Sending job: build:simple to localhost with params={'OFFLINE_NODE_WHEN_COMPLETE': 'false', 'uuid': '02d10fccf507473ba910d765de551def'}

Waiting for jobs to finish..............

-----  Job Results (Wed Aug 26 17:26:28 2015)  ------

98de47931e9548a6b92ed2dfede4b676 : ['{"manager":"host-10-0-0-11.openstacklocal","node_labels":["master","sun"],"name":"simple","worker":"host-10-0-0-11.openstacklocal_exec-0","number":10,"node_name":"","url":"http://15.125.107.245:8080/job/simple/10/"}', '{"result":"SUCCESS","manager":"host-10-0-0-11.openstacklocal","node_labels":["master","sun"],"name":"simple","worker":"host-10-0-0-11.openstacklocal_exec-0","number":10,"node_name":"","url":"http://15.125.107.245:8080/job/simple/10/"}']


67c03612bd844cbe90ece7449855c398 : ['{"manager":"host-10-0-0-11.openstacklocal","node_labels":["gcc","linux","linux-slave2","python24","ubuntu"],"name":"simple","worker":"linux-slave2_exec-0","number":11,"node_name":"linux-slave2","url":"http://15.125.107.245:8080/job/simple/11/"}', '{"result":"SUCCESS","manager":"host-10-0-0-11.openstacklocal","node_labels":["gcc","linux","linux-slave2","python24","ubuntu"],"name":"simple","worker":"linux-slave2_exec-0","number":11,"node_name":"linux-slave2","url":"http://15.125.107.245:8080/job/simple/11/"}']


02d10fccf507473ba910d765de551def : ['{"manager":"host-10-0-0-11.openstacklocal","node_labels":["centos","linux","linux-slave1","python27","torrent"],"name":"simple","worker":"linux-slave1_exec-0","number":12,"node_name":"linux-slave1","url":"http://15.125.107.245:8080/job/simple/12/"}', '{"result":"SUCCESS","manager":"host-10-0-0-11.openstacklocal","node_labels":["centos","linux","linux-slave1","python27","torrent"],"name":"simple","worker":"linux-slave1_exec-0","number":12,"node_name":"linux-slave1","url":"http://15.125.107.245:8080/job/simple/12/"}']

Patch-set: 10
This commit is contained in:
Gerrit User 6987 2015-08-26 17:37:38 +00:00 committed by Gerrit Code Review
parent fd4b1814cd
commit aca6e3c028
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available