x
/
gearman-plugin
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Gerrit User 6987 2015-07-23 15:35:33 +00:00 committed by Gerrit Code Review
parent fdac2e4732
commit fff6ffe758
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
f7bbb0f218f53b8c41e03b844007f063eb86d332
View File

@ -16,6 +16,23 @@
"revId": "f7bbb0f218f53b8c41e03b844007f063eb86d332",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a50d1a3_8344d249",
"filename": "src/main/java/hudson/plugins/gearman/StartJobWorker.java",
"patchSetId": 1
},
"lineNbr": 92,
"author": {
"id": 6987
},
"writtenOn": "2015-07-23T15:35:33Z",
"side": 1,
"message": "The AbstractBuild object has a method that will tell you the slave that the job was run on. So instead of getting the label maybe add \u0027builtOn\u0027 info? Also this may require some additional processing in zuul since our slaves have names like \"devstack-trusty-rax-dfw-3909105\". \n\nhere is the api:\nhttp://javadoc.jenkins-ci.org/hudson/model/AbstractBuild.html#getBuiltOn()",
"revId": "f7bbb0f218f53b8c41e03b844007f063eb86d332",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}