Update patch set 4

Browse Source

Patch Set 4:

This doesn't have much in the way of tests. I kept looking at it, and I don't see a good way of being able to unit test the method I added for gathering the constraints, as the method actually fetches URLs and writes to the filesystem. I could mock it, but that doesn't really test the code. Or I could break out a function to get the content from web, and break out a function to write it to disk, mock those, and test the returns of them, but that seems like a lot of very small functions.

Patch-set: 4
Reviewer: Gerrit User 6589 <6589@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0

...

This commit is contained in:

Gerrit User 6589 2016-06-11 01:16:32 +00:00 committed by Gerrit Code Review

parent ffddccac5b

commit 2b001a1250

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available