Update patch set 4

Patch Set 4: Code-Review+1

(1 comment)

One thing, filter is a bit of a generic term, and it's not clear if this is a 'negative filter' or 'positive filter'. What if we changed it to be called excludeproject or something like that?

Anyway, still +1 because it works and is only mildly vague.

Patch-set: 4
Reviewer: Gerrit User 6488 <6488@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
This commit is contained in:
Gerrit User 6488 2016-08-31 19:18:55 +00:00 committed by Gerrit Code Review
parent 8c19b32c51
commit 326c3532db
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "fa7ab95a_c046ba4e",
"filename": "giftwrap/tests/test_buildspec.py",
"patchSetId": 4
},
"lineNbr": 212,
"author": {
"id": 6488
},
"writtenOn": "2016-08-31T19:18:55Z",
"side": 1,
"message": "I wonder if we could assert that the name is the one filtered.. but this is good enough for me.",
"revId": "10af8d2d54a11a608507b84abf107fb017b5f707",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}