x
/
giftwrap
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(3 comments)

Patch-set: 4
Label: Code-Review=-1
This commit is contained in:
Gerrit User 6530 2016-06-15 16:46:54 +00:00 committed by Gerrit Code Review
parent 85b2c2c2b7
commit 9d90d1e1fe
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
75f97871c9b43531a70187d725c8800779a9c292 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "7aa08908_b23adc32",
"filename": "giftwrap/builders/__init__.py",
"patchSetId": 4
},
"lineNbr": 41,
"author": {
"id": 6530
},
"writtenOn": "2016-06-15T16:46:54Z",
"side": 1,
"message": "This should be _constraints.",
"revId": "75f97871c9b43531a70187d725c8800779a9c292",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_129e5063",
"filename": "giftwrap/builders/__init__.py",
"patchSetId": 4
},
"lineNbr": 79,
"author": {
"id": 6530
},
"writtenOn": "2016-06-15T16:46:54Z",
"side": 1,
"message": "A better way to do this is to use enumerate in the for loop.",
"revId": "75f97871c9b43531a70187d725c8800779a9c292",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_52029873",
"filename": "giftwrap/settings.py",
"patchSetId": 4
},
"lineNbr": 47,
"author": {
"id": 6530
},
"writtenOn": "2016-06-15T16:46:54Z",
"side": 1,
"message": "What happens if constraints is not a list?",
"revId": "75f97871c9b43531a70187d725c8800779a9c292",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}