x
/
giftwrap
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(4 comments)

I'll figure out how to add some tests, and address the other comments.

Patch-set: 2
Label: Verified=0
This commit is contained in:
Gerrit User 6589 2016-06-10 19:05:14 +00:00 committed by Gerrit Code Review
parent 7bbe88a3ae
commit b3fa3cd6d1
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
c16cc483183290aa84071eae22d491573de469e7
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_8d3781af",
"filename": "giftwrap/builders/__init__.py",
"patchSetId": 2
},
"lineNbr": 63,
"author": {
"id": 6589
},
"writtenOn": "2016-06-10T19:05:14Z",
"side": 1,
"message": "Ah, well, it wasn\u0027t quite so spaced out when I first submitted. It got spaced out as I responded to review. I can definitely clean it back up, and use more descriptive names.",
"parentUuid": "7aa08908_3b1b321e",
"revId": "c16cc483183290aa84071eae22d491573de469e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_bb0722c8",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_cd5869fd",
"filename": "giftwrap/builders/__init__.py",
"patchSetId": 2
},
"lineNbr": 106,
"author": {
"id": 6589
},
"writtenOn": "2016-06-10T19:05:14Z",
"side": 1,
"message": "Ah, I did this wrong then. For this first pass, yes I wanted the constraints load to be per-build, not per project. I stuffed the code into the wrong place obviously. I\u0027ll move it around.",
"parentUuid": "7aa08908_bb0722c8",
"revId": "c16cc483183290aa84071eae22d491573de469e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_5e20ac49",
@ -51,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_0d739181",
"filename": "giftwrap/builders/docker_builder.py",
"patchSetId": 2
},
"lineNbr": 67,
"author": {
"id": 6589
},
"writtenOn": "2016-06-10T19:05:14Z",
"side": 1,
"message": "Indeed, however that\u0027s beyond the scope of this change request :)",
"parentUuid": "7aa08908_5e20ac49",
"revId": "c16cc483183290aa84071eae22d491573de469e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_3bc5f23c",
@ -67,6 +121,24 @@
"revId": "c16cc483183290aa84071eae22d491573de469e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_cd0fc9df",
"filename": "giftwrap/builders/docker_builder.py",
"patchSetId": 2
},
"lineNbr": 88,
"author": {
"id": 6589
},
"writtenOn": "2016-06-10T19:05:14Z",
"side": 1,
"message": "that makes it a bit awkward, as \"uses_constraints\" sounds like a boolean, and yet what you\u0027re returning is a path. I can do that, just feels a tad awkward.",
"parentUuid": "7aa08908_3bc5f23c",
"revId": "c16cc483183290aa84071eae22d491573de469e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}