x
/
giftwrap
Code Issues Proposed changes

Use quotes around pip requirements 

If a version is expressed, the carrot could do shell redirection instead
of the version expression.

Change-Id: I6e1f2f61443980162e14c6a6cbde4fb7405e915f
This commit is contained in:
Jesse Keating 2016-02-16 16:32:38 +00:00
parent 4946801f16
commit d6c4436aa6
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
giftwrap/builders/docker_builder.py
View File

@ -88,7 +88,7 @@ class DockerBuilder(Builder):
for constraint in self._constraints:
install = "%s -c %s" % (install, constraint)
for dependency in dependencies:
self._execute("%s %s %s" % (pip_path, install, dependency))
self._execute("%s %s '%s'" % (pip_path, install, dependency))
def _copy_sample_config(self, src_clone_dir, project):
src_config = os.path.join(src_clone_dir, 'etc')

2
giftwrap/builders/package_builder.py
View File

@ -74,7 +74,7 @@ class PackageBuilder(Builder):
for constraint in self._constraints:
install = "%s -c %s" % (install, constraint)
for dependency in dependencies:
self._execute("%s %s %s" % (pip_path, install, dependency))
self._execute("%s %s '%s'" % (pip_path, install, dependency))
def _copy_sample_config(self, src_clone_dir, project):
src_config = os.path.join(src_clone_dir, 'etc')