x
/
gitdm
Code Issues Proposed changes

gitdm: Report progress to stderr not stdout 

When gitdm is used for generating text-only report with its output
redirected to a file, all is well aside from the clutter at the beginning
of that file -- a very long line with repeating "Grabbing changesets...".

Solve that by redirecting progress reporting to stderr. It also helps to
see the progress when you redirect gitdm output to a file.

Also, we don't have to flush stdout since stderr is unbuffered by default.

Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
This commit is contained in:
Kir Kolyshkin 2008-04-07 23:59:18 +04:00 committed by Jonathan Corbet
parent e1a6d06d65
commit 3d9830c3ce
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gitdm
View File

@ -447,14 +447,12 @@ ParseOpts ()
#
# Snarf changesets.
#
print 'Grabbing changesets...\r',
sys.stdout.flush ()
print >> sys.stderr, 'Grabbing changesets...\r',
printcount = CSCount = 0
while (1):
if (printcount % 50) == 0:
print 'Grabbing changesets...%d\r' % printcount,
sys.stdout.flush ()
print >> sys.stderr, 'Grabbing changesets...%d\r' % printcount,
printcount += 1
p = grabpatch()
if not p:
@ -469,7 +467,7 @@ while (1):
for sobemail, sob in p.sobs:
sob.addsob (p)
CSCount += 1
print 'Grabbing changesets...done'
print >> sys.stderr, 'Grabbing changesets...done'
if DumpDB:
database.DumpDB ()