x
/
group-based-policy-specs
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(11 comments)

Thanks Thomas for the latest revision, just a few more comments and we can close after that.

Patch-set: 7
Label: Verified=0
This commit is contained in:
Gerrit User 490 2017-05-08 05:32:01 +00:00 committed by Gerrit Code Review
parent f80a5cc872
commit c0c9379bcc
1 changed files with 197 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

197
40c76f13cc12b28bc82e4419064b822615a73d9d Normal file
View File

@ -0,0 +1,197 @@
{
"comments": [
{
"key": {
"uuid": "3f044301_e31caf6b",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 48,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "So today the ip_pool is optional, and if nothing is supplied, validation succeeds for the \u0027None\u0027 value, but the default CIDR of 10.0.0.0/8 gets set for the ip_pool. Is this behavior changing? If so, we should document how that is changing.",
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f044301_c33093eb",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 66,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "So ipv6 is always 64? and if so, it will be good to document that here. (You have mentioned it later in the spec but perhaps good to state it here as well.)",
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f044301_ed6380db",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 69,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "nit: I wonder if a value of 32 or 31 would be relevant either.",
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f044301_839e0bb6",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 71,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "nit: Suggest rewording:\n\nAn address scope has two properties, it defines an address namespace, and the routability.",
"range": {
"startLine": 71,
"startChar": 0,
"endLine": 71,
"endChar": 71
},
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f044301_c3b3f34c",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 80,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "router -\u003e neutron router",
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f044301_637e5f6c",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 83,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "...and a PTG in the other l3_policy consuming that external_policy.",
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f044301_83c16be7",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 104,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "A default subnetpool (defined in Neutron)...",
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f044301_a61475a1",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 125,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "If a GET request is made, will the ip_pool be set to reflect the CIDRs in the subnetpool? If so, might be good to mention it here (though its being mentioned later as well).",
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f044301_a6c7d512",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 195,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "...is increased to 256 (from 64) in order...",
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f044301_663b0deb",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 358,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "whats the change here?",
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f044301_a631150e",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 7
},
"lineNbr": 427,
"author": {
"id": 490
},
"writtenOn": "2017-05-08T05:32:01Z",
"side": 1,
"message": "I am not sure that this change is necessary, since the ip_pool is going to be treated as a string at the API layer (perhaps this is leftover from the previous iterations).",
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}