Update patch set 4
Patch Set 4: (9 comments) Patch-set: 4 Label: Verified=0
This commit is contained in:
Gerrit User 1689
Gerrit Code Review
parent
7f822624ea
commit
e95fb3abc8
|
|
@ -0,0 +1,211 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_421fb0b6",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 46,
|
||||
"author": {
|
||||
"id": 1689
|
||||
},
|
||||
"writtenOn": "2017-04-27T19:17:46Z",
|
||||
"side": 1,
|
||||
"message": "typo: \"explicitly\"",
|
||||
"range": {
|
||||
"startLine": 46,
|
||||
"startChar": 61,
|
||||
"endLine": 46,
|
||||
"endChar": 72
|
||||
},
|
||||
"revId": "2b0c96940f82c866c13dc27a530ec3ac5af97a72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_eba8b920",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 87,
|
||||
"author": {
|
||||
"id": 1689
|
||||
},
|
||||
"writtenOn": "2017-04-27T19:17:46Z",
|
||||
"side": 1,
|
||||
"message": "delete",
|
||||
"range": {
|
||||
"startLine": 87,
|
||||
"startChar": 38,
|
||||
"endLine": 87,
|
||||
"endChar": 51
|
||||
},
|
||||
"revId": "2b0c96940f82c866c13dc27a530ec3ac5af97a72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_6b43896d",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 90,
|
||||
"author": {
|
||||
"id": 1689
|
||||
},
|
||||
"writtenOn": "2017-04-27T19:17:46Z",
|
||||
"side": 1,
|
||||
"message": "\"is\"\n\nI think subnet_prefix_length is used later when allocating IPv4 subnets, so lets not say it is ignored.",
|
||||
"range": {
|
||||
"startLine": 90,
|
||||
"startChar": 16,
|
||||
"endLine": 90,
|
||||
"endChar": 67
|
||||
},
|
||||
"revId": "2b0c96940f82c866c13dc27a530ec3ac5af97a72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_6b3829ed",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 91,
|
||||
"author": {
|
||||
"id": 1689
|
||||
},
|
||||
"writtenOn": "2017-04-27T19:17:46Z",
|
||||
"side": 1,
|
||||
"message": "delete",
|
||||
"range": {
|
||||
"startLine": 91,
|
||||
"startChar": 46,
|
||||
"endLine": 91,
|
||||
"endChar": 59
|
||||
},
|
||||
"revId": "2b0c96940f82c866c13dc27a530ec3ac5af97a72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_867c8c83",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 98,
|
||||
"author": {
|
||||
"id": 1689
|
||||
},
|
||||
"writtenOn": "2017-04-27T19:17:46Z",
|
||||
"side": 1,
|
||||
"message": "This paragraph only applies to the second case. If an implicit subnetpool is used, that subnetpool is not modified. Maybe move this up to the above 2nd case paragraph.",
|
||||
"range": {
|
||||
"startLine": 98,
|
||||
"startChar": 3,
|
||||
"endLine": 98,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "2b0c96940f82c866c13dc27a530ec3ac5af97a72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_a685485c",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 113,
|
||||
"author": {
|
||||
"id": 1689
|
||||
},
|
||||
"writtenOn": "2017-04-27T19:17:46Z",
|
||||
"side": 1,
|
||||
"message": "\"ip_pool values\"\n\nNo need to mention subnet_prefix_length being ignored since it may be used when allocating subnets.",
|
||||
"range": {
|
||||
"startLine": 113,
|
||||
"startChar": 3,
|
||||
"endLine": 113,
|
||||
"endChar": 34
|
||||
},
|
||||
"revId": "2b0c96940f82c866c13dc27a530ec3ac5af97a72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_c66734b7",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 154,
|
||||
"author": {
|
||||
"id": 1689
|
||||
},
|
||||
"writtenOn": "2017-04-27T19:17:46Z",
|
||||
"side": 1,
|
||||
"message": "I\u0027m not sure any of this is needed if we are specifying separately how subnet_prefix_length is used for IPv4 subnet allocation. Its really only ip_pool whose value after creation needs to be described.",
|
||||
"range": {
|
||||
"startLine": 146,
|
||||
"startChar": 51,
|
||||
"endLine": 154,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "2b0c96940f82c866c13dc27a530ec3ac5af97a72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_26fa58bc",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 271,
|
||||
"author": {
|
||||
"id": 1689
|
||||
},
|
||||
"writtenOn": "2017-04-27T19:17:46Z",
|
||||
"side": 1,
|
||||
"message": "\"type:subnet_list\"?",
|
||||
"range": {
|
||||
"startLine": 271,
|
||||
"startChar": 34,
|
||||
"endLine": 271,
|
||||
"endChar": 45
|
||||
},
|
||||
"revId": "2b0c96940f82c866c13dc27a530ec3ac5af97a72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_a62f883d",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 277,
|
||||
"author": {
|
||||
"id": 1689
|
||||
},
|
||||
"writtenOn": "2017-04-27T19:17:46Z",
|
||||
"side": 1,
|
||||
"message": "something is needed here to allow None if we are going to do that.",
|
||||
"range": {
|
||||
"startLine": 273,
|
||||
"startChar": 32,
|
||||
"endLine": 277,
|
||||
"endChar": 68
|
||||
},
|
||||
"revId": "2b0c96940f82c866c13dc27a530ec3ac5af97a72",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue