From 6693ec2398b192d3b4d0968e7be3e9c11228533d Mon Sep 17 00:00:00 2001 From: Dmitry Tantsur Date: Wed, 24 Oct 2018 15:30:59 +0200 Subject: [PATCH] Add noop management to iBOOT and WOL hardware types The classic drivers had management=None, so no management actions were tried. The hardware types have management=fake, which does not support local boot. This ends up in a serious feature regression. The intended behavior is to use static boot management, which is what the noop management is about, so use it. Change-Id: Id46e2747facabda922e1544fa59e90fb31a04a62 (cherry picked from commit 58fe0fe457f87d2d518d0d4162807d4cf3703082) --- ironic_staging_drivers/iboot/__init__.py | 3 ++- ironic_staging_drivers/wol/__init__.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ironic_staging_drivers/iboot/__init__.py b/ironic_staging_drivers/iboot/__init__.py index 36e9ef5..5fc8717 100644 --- a/ironic_staging_drivers/iboot/__init__.py +++ b/ironic_staging_drivers/iboot/__init__.py @@ -16,6 +16,7 @@ from ironic.drivers import generic from ironic.drivers.modules import fake +from ironic.drivers.modules import noop_mgmt from ironic_staging_drivers.iboot import power as iboot_power @@ -29,7 +30,7 @@ class IBootHardware(generic.GenericHardware): @property def supported_management_interfaces(self): """List of supported management interfaces.""" - return [fake.FakeManagement] + return [noop_mgmt.NoopManagement, fake.FakeManagement] @property def supported_power_interfaces(self): diff --git a/ironic_staging_drivers/wol/__init__.py b/ironic_staging_drivers/wol/__init__.py index 79abf7d..128cbb9 100644 --- a/ironic_staging_drivers/wol/__init__.py +++ b/ironic_staging_drivers/wol/__init__.py @@ -15,6 +15,7 @@ from ironic.drivers import generic from ironic.drivers.modules import fake +from ironic.drivers.modules import noop_mgmt from ironic_staging_drivers.wol import power as wol_power @@ -28,7 +29,7 @@ class WOLHardware(generic.GenericHardware): @property def supported_management_interfaces(self): """List of supported management interfaces.""" - return [fake.FakeManagement] + return [noop_mgmt.NoopManagement, fake.FakeManagement] @property def supported_power_interfaces(self):