x
/
ironic-staging-drivers
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review+1

(1 comment)

I don't actually have approve rights on this repo, adding Julia

Patch-set: 4
Reviewer: Gerrit User 11655 <11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 4571 <4571@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
This commit is contained in:
Gerrit User 4571 2021-04-08 02:09:19 +00:00 committed by Gerrit Code Review
parent 4499cfdad9
commit 886a8f7e83
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
a94fc0ac23c207f3d012b3b1ad313f46dd55bd68 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3bfc72a3_b64625c5",
"filename": "ironic_staging_drivers/ovirt/ovirt.py",
"patchSetId": 4
},
"lineNbr": 143,
"author": {
"id": 4571
},
"writtenOn": "2021-04-08T02:09:19Z",
"side": 1,
"message": "ah, so the purpose of the encode is to validate that it is ascii, so it shouldn\u0027t be assigned back to the url variable because then it will be a binary not a string.",
"revId": "a94fc0ac23c207f3d012b3b1ad313f46dd55bd68",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}