Update patch set 1

Patch Set 1: Code-Review-1 (7 comments) Some comments Patch-set: 1 Label: Code-Review=-1
2015-09-15 17:17:42 +00:00 · 2015-09-15 17:17:42 +00:00 · 3328287281
parent bd492a187c
commit 3328287281
1 changed files with 123 additions and 0 deletions
--- a/123
+++ b/123
@ -0,0 +1,123 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "ba15a1d1_22bb1610",
+        "filename": "specs/liberty/sysarch-diagram.dot",
+        "patchSetId": 1
+      },
+      "lineNbr": 30,
+      "author": {
+        "id": 11628
+      },
+      "writtenOn": "2015-09-15T17:17:42Z",
+      "side": 1,
+      "message": "Are we keeping status history in the Database or should we have some sort of logging component or call out?",
+      "revId": "e887425fcf92368c4d85db6972b81f43f9ad8c03",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba15a1d1_a22ac62a",
+        "filename": "specs/liberty/sysarch-diagram.dot",
+        "patchSetId": 1
+      },
+      "lineNbr": 43,
+      "author": {
+        "id": 11628
+      },
+      "writtenOn": "2015-09-15T17:17:42Z",
+      "side": 1,
+      "message": "Should we call out an HA strategy now or in a later change?  For example, I would expect to ahve the GSLB Appliance in some kind of HA configuration, VRRP or LVS?",
+      "revId": "e887425fcf92368c4d85db6972b81f43f9ad8c03",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba15a1d1_82830204",
+        "filename": "specs/liberty/sysarch-diagram.dot",
+        "patchSetId": 1
+      },
+      "lineNbr": 47,
+      "author": {
+        "id": 11628
+      },
+      "writtenOn": "2015-09-15T17:17:42Z",
+      "side": 1,
+      "message": "Dashed seems to indicate components not implemented by GSLB.  Shouldn\u0027t this be solid lined?",
+      "revId": "e887425fcf92368c4d85db6972b81f43f9ad8c03",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba15a1d1_62acaeed",
+        "filename": "specs/liberty/sysarch-diagram.dot",
+        "patchSetId": 1
+      },
+      "lineNbr": 49,
+      "author": {
+        "id": 11628
+      },
+      "writtenOn": "2015-09-15T17:17:42Z",
+      "side": 1,
+      "message": "We are missing a data flow for the GSLB Traffic Director to get/access status information.  Or maybe it just isn\u0027t clear.\nIs status information going into \"Status Check Consumer\" and then changes pushed to the \"GSLB Traffic Director\" via GSLB Plugin Interface and GSLB Plugin Driver?\nIs that necessary, or is there a direct way between \"Status Check Service\" and \"GSLB Appliance\"?  (Just asking the question, not advocating)\nDoes the \"Engine Service\" update both the GSLB appliance and the database for status changes?  How does the end user see their status?",
+      "revId": "e887425fcf92368c4d85db6972b81f43f9ad8c03",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba15a1d1_a20de638",
+        "filename": "specs/liberty/sysarch-diagram.dot",
+        "patchSetId": 1
+      },
+      "lineNbr": 67,
+      "author": {
+        "id": 11628
+      },
+      "writtenOn": "2015-09-15T17:17:42Z",
+      "side": 1,
+      "message": "We are not calling out LBaaS anywhere here.  That can be ok if we are going forward with a plan that the Endpoints can be LBaaS listeners or anything else and we don\u0027t plan to automate the LBaaS part.",
+      "revId": "e887425fcf92368c4d85db6972b81f43f9ad8c03",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba15a1d1_02f372d7",
+        "filename": "specs/liberty/sysarch-diagram.dot",
+        "patchSetId": 1
+      },
+      "lineNbr": 99,
+      "author": {
+        "id": 11628
+      },
+      "writtenOn": "2015-09-15T17:17:42Z",
+      "side": 1,
+      "message": "These are bi-directional connectors I expect.",
+      "revId": "e887425fcf92368c4d85db6972b81f43f9ad8c03",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba15a1d1_5f22a3ba",
+        "filename": "specs/liberty/sysarch-diagram.dot",
+        "patchSetId": 1
+      },
+      "lineNbr": 107,
+      "author": {
+        "id": 11628
+      },
+      "writtenOn": "2015-09-15T17:17:42Z",
+      "side": 1,
+      "message": "Does the GSLB Traffic Director really make connections to the Endpoints?\nThis seems deceiving, as we are not proxying the traffic.",
+      "revId": "e887425fcf92368c4d85db6972b81f43f9ad8c03",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}