Update patch set 5

Patch Set 5: (4 comments) Patch-set: 5 Reviewer: Gerrit User 8290 <8290@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
2017-11-23 05:53:35 +00:00 · 2017-11-23 05:53:35 +00:00 · 9a87e4e4db
parent 666a14930c
commit 9a87e4e4db
1 changed files with 90 additions and 0 deletions
--- a/90
+++ b/90
@ -0,0 +1,90 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "ff82abbf_10425011",
+        "filename": "specs/queens/approved/unmanage-existing-bms.rst",
+        "patchSetId": 5
+      },
+      "lineNbr": 29,
+      "author": {
+        "id": 8290
+      },
+      "writtenOn": "2017-11-23T05:53:35Z",
+      "side": 1,
+      "message": "sorry, I didn\u0027t get this clearly, maybe you can make an example with a \"source OpenStack\" and a \"destination OpenStack\" ?",
+      "range": {
+        "startLine": 28,
+        "startChar": 44,
+        "endLine": 29,
+        "endChar": 73
+      },
+      "revId": "2dd239630234f8a3f0ceaa2631467b39a086a4a4",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ff82abbf_b069248c",
+        "filename": "specs/queens/approved/unmanage-existing-bms.rst",
+        "patchSetId": 5
+      },
+      "lineNbr": 31,
+      "author": {
+        "id": 8290
+      },
+      "writtenOn": "2017-11-23T05:53:35Z",
+      "side": 1,
+      "message": "also it is better to illustrate with a source\u0026dest OpenStack cloud. and, according to my understanding, this \"after\" should be \"before\", am I wrong ? :D",
+      "range": {
+        "startLine": 31,
+        "startChar": 65,
+        "endLine": 31,
+        "endChar": 70
+      },
+      "revId": "2dd239630234f8a3f0ceaa2631467b39a086a4a4",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ff82abbf_10ded03e",
+        "filename": "specs/queens/approved/unmanage-existing-bms.rst",
+        "patchSetId": 5
+      },
+      "lineNbr": 53,
+      "author": {
+        "id": 8290
+      },
+      "writtenOn": "2017-11-23T05:53:35Z",
+      "side": 1,
+      "message": "don\u0027t need to do any change in Ironic ?",
+      "revId": "2dd239630234f8a3f0ceaa2631467b39a086a4a4",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ff82abbf_90cae06a",
+        "filename": "specs/queens/approved/unmanage-existing-bms.rst",
+        "patchSetId": 5
+      },
+      "lineNbr": 71,
+      "author": {
+        "id": 8290
+      },
+      "writtenOn": "2017-11-23T05:53:35Z",
+      "side": 1,
+      "message": "looks a bit weird, since this \"DELETE\" can \"delete\" a node which may not existed in the output of GET /.../manageable_servers/, but it is ok for me.",
+      "range": {
+        "startLine": 71,
+        "startChar": 5,
+        "endLine": 71,
+        "endChar": 45
+      },
+      "revId": "2dd239630234f8a3f0ceaa2631467b39a086a4a4",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}