Update patch set 2

Patch Set 2: Code-Review-1 (7 comments) Patch-set: 2 Label: Code-Review=-1
2017-10-24 02:59:53 +00:00 · 2017-10-24 02:59:53 +00:00 · ffa10d2c34
parent 31ade5c83d
commit ffa10d2c34
1 changed files with 165 additions and 0 deletions
--- a/165
+++ b/165
@ -0,0 +1,165 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3f4b6375_1eeb5a13",
+        "filename": "specs/queens/approved/rsd-integration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 11,
+      "author": {
+        "id": 6610
+      },
+      "writtenOn": "2017-10-24T02:59:53Z",
+      "side": 1,
+      "message": "this link can not be found.",
+      "range": {
+        "startLine": 11,
+        "startChar": 0,
+        "endLine": 11,
+        "endChar": 60
+      },
+      "revId": "8a20d6ac300a5556b8878b86fe4e0bb171d99061",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f4b6375_dec942ac",
+        "filename": "specs/queens/approved/rsd-integration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 40,
+      "author": {
+        "id": 6610
+      },
+      "writtenOn": "2017-10-24T02:59:53Z",
+      "side": 1,
+      "message": "can you elaborate this? there\u0027s also someone pointed out that we should get rid of flavor and provide such parameters instead.",
+      "range": {
+        "startLine": 40,
+        "startChar": 20,
+        "endLine": 40,
+        "endChar": 75
+      },
+      "revId": "8a20d6ac300a5556b8878b86fe4e0bb171d99061",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f4b6375_5ebd5200",
+        "filename": "specs/queens/approved/rsd-integration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 46,
+      "author": {
+        "id": 6610
+      },
+      "writtenOn": "2017-10-24T02:59:53Z",
+      "side": 1,
+      "message": "seems already supported, can you confirm this?",
+      "range": {
+        "startLine": 46,
+        "startChar": 15,
+        "endLine": 46,
+        "endChar": 33
+      },
+      "revId": "8a20d6ac300a5556b8878b86fe4e0bb171d99061",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f4b6375_fe3d1e8f",
+        "filename": "specs/queens/approved/rsd-integration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 48,
+      "author": {
+        "id": 6610
+      },
+      "writtenOn": "2017-10-24T02:59:53Z",
+      "side": 1,
+      "message": "we have replaced this with server :D",
+      "range": {
+        "startLine": 48,
+        "startChar": 8,
+        "endLine": 48,
+        "endChar": 16
+      },
+      "revId": "8a20d6ac300a5556b8878b86fe4e0bb171d99061",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f4b6375_be11e606",
+        "filename": "specs/queens/approved/rsd-integration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 61,
+      "author": {
+        "id": 6610
+      },
+      "writtenOn": "2017-10-24T02:59:53Z",
+      "side": 1,
+      "message": "in fact, we only have a OnFailureRescheduleTask in the workflow, and the scheduling is triggered before we reach the workflow, so maybe just pass some parameter to incate that we don\u0027t need to reschedule, anyhow, need to give more information here.",
+      "range": {
+        "startLine": 61,
+        "startChar": 20,
+        "endLine": 61,
+        "endChar": 46
+      },
+      "revId": "8a20d6ac300a5556b8878b86fe4e0bb171d99061",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f4b6375_5e00b2ab",
+        "filename": "specs/queens/approved/rsd-integration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 69,
+      "author": {
+        "id": 6610
+      },
+      "writtenOn": "2017-10-24T02:59:53Z",
+      "side": 1,
+      "message": "I think you mean server here.",
+      "range": {
+        "startLine": 69,
+        "startChar": 16,
+        "endLine": 69,
+        "endChar": 20
+      },
+      "revId": "8a20d6ac300a5556b8878b86fe4e0bb171d99061",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f4b6375_de25c25d",
+        "filename": "specs/queens/approved/rsd-integration.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 89,
+      "author": {
+        "id": 6610
+      },
+      "writtenOn": "2017-10-24T02:59:53Z",
+      "side": 1,
+      "message": "instead of adding a first class filed, maybe we should consider to introduce something like system metadata to store such informations.",
+      "range": {
+        "startLine": 89,
+        "startChar": 2,
+        "endLine": 89,
+        "endChar": 10
+      },
+      "revId": "8a20d6ac300a5556b8878b86fe4e0bb171d99061",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}