Update patch set 4

Browse Source

Patch Set 4: Code-Review-1

Why hold it back. Add your smoke2.yml to the mini-mon.yml so it gets run automatically.

What is the point in checking for apt/pip packages? This is handled by Ansible and if the Ansible somehow missed one then the entire process would presumably fail to run and you would see it then. Avoiding checking allows us flexibility to use a different OS in the future.

I would love a way to avoid maintaining a config file with info in it that is largely a replica of the true source, ie list of topics, schema tables etc. Certainly the bits of info already set in Ansible shouldn't be replicated in another config file, rather make it into a template that you could populate from Ansible. That way the Ansible config is the single source of truth for that info.

Am I missing something it looks like if you don't specify the arguments it will skip a lot of checks even though you could have the required information in the config file. Single mode runs differently but even for cluster mode I think the default should be to run all checks and opt out rather than in.

Patch-set: 4
Label: Code-Review=-1

...

This commit is contained in:

Gerrit User 11094 2015-06-11 16:24:28 +00:00 committed by Gerrit Code Review

parent fd82f53da5

commit 183ff55cc1

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available