Update patch set 9

Patch Set 9:

(2 comments)

The making of the script a template strikes me as odd. I think the config should be a template. Sorry if my last post was confusing on that point.

I did test this change and it worked well. I would like to see some cleanup but it is okay by me if that is done in another pull request and this one is approved.

Patch-set: 9
Label: Verified=0
This commit is contained in:
Gerrit User 11094 2015-06-19 15:23:04 +00:00 committed by Gerrit Code Review
parent 40e5af9d11
commit 5fca44661b
1 changed files with 38 additions and 0 deletions

View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "fa32b979_b97b2529",
"filename": "tests/smoke2.py.j2",
"patchSetId": 9
},
"lineNbr": 213,
"author": {
"id": 11094
},
"writtenOn": "2015-06-19T15:23:04Z",
"side": 1,
"message": "This should be a warning.",
"revId": "3d1134c34f49bb2f2f8aca6e51babdbaf5a9fe2f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa32b979_f60a1a79",
"filename": "tests/smoke2.py.j2",
"patchSetId": 9
},
"lineNbr": 396,
"author": {
"id": 11094
},
"writtenOn": "2015-06-19T15:23:04Z",
"side": 1,
"message": "This default 0 is odd. Though python allows it checking that the value of a string isn\u0027t equal to an int is odd. Why not just let it be an empty string and check for that.",
"revId": "3d1134c34f49bb2f2f8aca6e51babdbaf5a9fe2f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}