x
/
monasca-vagrant
Code Issues Proposed changes

Update patch set 10 

Patch Set 10: Code-Review-1

(2 comments)

These changes look great! I just noted a couple of real minor things to fix up quickly.

Patch-set: 10
Label: Code-Review=-1
This commit is contained in:
Gerrit User 11094 2015-06-19 17:28:17 +00:00 committed by Gerrit Code Review
parent ec826c66b2
commit 994b10c573
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
64ededbdf9beed035e77f438cc05587a71997fc7 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "fa32b979_edc0007f",
"filename": "smoke2.yml",
"patchSetId": 10
},
"lineNbr": 8,
"author": {
"id": 11094
},
"writtenOn": "2015-06-19T17:28:17Z",
"side": 1,
"message": "No need for this step, vagrant mounts the working dir at /vagran the script is already there.",
"revId": "64ededbdf9beed035e77f438cc05587a71997fc7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa32b979_4d048cc5",
"filename": "tests/smoke2.py",
"patchSetId": 10
},
"lineNbr": 429,
"author": {
"id": 11094
},
"writtenOn": "2015-06-19T17:28:17Z",
"side": 1,
"message": "Looks great, could you add a comment briefly saying what the stages cover",
"revId": "64ededbdf9beed035e77f438cc05587a71997fc7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}