Remove requests.packages.urllib3.disable_warnings()

Remove requests.packages.urllib3.disable_warnings() from
unit testcase because it is not affacting unit testcase.
Means no warning log without
requests.packages.urllib3.disable_warnings().

But keep as it is in main code because we are using
it at one place only.
https://github.com/openstack/nova-dpm/blob/stable/ocata/nova_dpm/virt/dpm/client_proxy.py#L41

Closes-Bug: #1669299

Change-Id: I2eefc01743c2549ebe8cdc32eb95d03a05f7bc0f
Signed-off-by: Prabhat Ranjan <pranjank@in.ibm.com>

nova_dpm/tests/unit/virt/dpm/test_driver.py

@@ -28,7 +28,6 @@ from nova_dpm.virt.dpm.volume import fibrechannel
 
 
 import mock
-import requests.packages.urllib3
 import zhmcclient
 import zhmcclient_mock
 
@@ -69,7 +68,6 @@ class DPMdriverInitHostTestCase(TestCase):
 
     def setUp(self):
         super(DPMdriverInitHostTestCase, self).setUp()
-        requests.packages.urllib3.disable_warnings()
         self.session = fake_session()
         self.client = zhmcclient.Client(self.session)
         self.dpmdriver = driver.DPMDriver(None)
@@ -259,7 +257,6 @@ class DPMDriverInstanceTestCase(TestCase):
 
     def setUp(self):
         super(DPMDriverInstanceTestCase, self).setUp()
-        requests.packages.urllib3.disable_warnings()
         self.session = utils.create_session_1()
         self.client = zhmcclient.Client(self.session)
         self.dpmdriver = driver.DPMDriver(None)

nova_dpm/tests/unit/virt/dpm/test_host.py

@@ -13,7 +13,6 @@
 # limitations under the License.
 
 import json
-import requests.packages.urllib3
 import zhmcclient
 
 from nova.test import TestCase
@@ -25,7 +24,6 @@ class HostTestCase(TestCase):
 
     def setUp(self):
         super(HostTestCase, self).setUp()
-        requests.packages.urllib3.disable_warnings()
         self.session = utils.create_session_1()
         client = zhmcclient.Client(self.session)
         self.cpc = client.cpcs.find(**{"name": "cpc_2"})

nova_dpm/tests/unit/virt/dpm/test_utils.py

@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import requests.packages.urllib3
 import zhmcclient
 import zhmcclient_mock
 
@@ -25,7 +24,6 @@ class HostTestCase(TestCase):
 
     def setUp(self):
         super(HostTestCase, self).setUp()
-        requests.packages.urllib3.disable_warnings()
 
         session = zhmcclient_mock.FakedSession(
             'fake-host', 'fake-hmc', '2.13.1', '1.8')
@@ -65,7 +63,6 @@ class HostTestCase(TestCase):
         utils.validate_host_conf(self.cpc)
 
     def test_dpm_enabled_false(self):
-        requests.packages.urllib3.disable_warnings()
 
         session = zhmcclient_mock.FakedSession(
             'fake-host', 'fake-hmc', '2.13.1', '1.8')

nova_dpm/tests/unit/virt/dpm/test_vm.py

@@ -20,7 +20,6 @@ from nova.objects import instance as instance_obj
 from nova.test import TestCase
 from nova_dpm.virt.dpm import exceptions
 from nova_dpm.virt.dpm import vm
-import requests.packages.urllib3
 import zhmcclient
 import zhmcclient_mock
 
@@ -95,7 +94,6 @@ class ValidPartitionNameTestCase(TestCase):
 class VmPartitionInstanceTestCase(TestCase):
     def setUp(self):
         super(VmPartitionInstanceTestCase, self).setUp()
-        requests.packages.urllib3.disable_warnings()
 
         self.session = fake_session()
         self.client = zhmcclient.Client(self.session)
@@ -272,7 +270,6 @@ class PhysicalAdapterModelTestCase(TestCase):
 
     def setUp(self):
         super(PhysicalAdapterModelTestCase, self).setUp()
-        requests.packages.urllib3.disable_warnings()
         self.session = fake_session()
         self.client = zhmcclient.Client(self.session)
         self.cpc = self.client.cpcs.find(**{"name": "cpc_1"})
@@ -301,7 +298,6 @@ class PartitionInstanceInfoTestCase(TestCase):
 
     def setUp(self):
         super(PartitionInstanceInfoTestCase, self).setUp()
-        requests.packages.urllib3.disable_warnings()
         self.session = fake_session()
         self.client = zhmcclient.Client(self.session)
         self.cpcs = self.client.cpcs.list()

nova_dpm/virt/dpm/client_proxy.py

@@ -36,8 +36,6 @@ def import_zhmcclient():
     """
 
     LOG.debug("get_zhmcclient")
-    # TODO(preethipy): The below line will be removed once the warnings are
-    # supressed within zhmclient code
     requests.packages.urllib3.disable_warnings()
 
     global zhmcclient