x
/
nova-lxd
Code Issues Proposed changes

Using assertIsNone(xxx) instead of assertEqual(None, xxx) 

Refer to OpenStack Style Guidelines:
https://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(xxx) is preferred over
assertEqual(None, xxx)

Change-Id: I8ccc344a40762ddc01253e23b533e27f3618d5f1
This commit is contained in:
Vu Cong Tuan 2017-06-03 16:12:48 +07:00
parent 52232047f1
commit 2760941c2f
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
nova/tests/unit/virt/lxd/test_session.py
View File

@ -61,8 +61,7 @@ class SessionContainerTest(test.NoDBTestCase):
self.ml.container_init.return_value = side_effect
self.ml.operation_info.return_value = \
(200, fake_api.fake_container_state(200))
self.assertEqual(None,
self.session.container_init(config, instance))
self.assertIsNone(self.session.container_init(config, instance))
calls = [mock.call.container_init(config),
mock.call.wait_container_operation(
'/1.0/operation/1234', 200, -1),
@ -105,7 +104,6 @@ class SessionEventTest(test.NoDBTestCase):
instance = stubs._fake_instance()
operation_id = mock.Mock()
self.ml.wait_container_operation.return_value = True
self.assertEqual(None,
self.session.operation_wait(operation_id, instance))
self.assertIsNone(self.session.operation_wait(operation_id, instance))
self.ml.wait_container_operation.assert_called_with(operation_id,
200, -1)