Update patch set 2

Patch Set 2:

(6 comments)

looking great!

Patch-set: 2
Reviewer: Gerrit User 2 <2@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 2 2016-11-15 16:26:54 +00:00 committed by Gerrit Code Review
parent b3a68fb542
commit 4aa736af63
1 changed files with 106 additions and 0 deletions

View File

@ -0,0 +1,106 @@
{
"comments": [
{
"key": {
"uuid": "7a77a97e_4b781bf3",
"filename": "oaktreemodel/model.py",
"patchSetId": 2
},
"lineNbr": 24,
"author": {
"id": 2
},
"writtenOn": "2016-11-15T16:26:54Z",
"side": 1,
"message": "this\u0027ll want to be oaktreemodel.network_pb2",
"revId": "e68b83054f9892161aba92917117a3b28beb2c63",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a77a97e_cbd18bcf",
"filename": "oaktreemodel/network.proto",
"patchSetId": 2
},
"lineNbr": 26,
"author": {
"id": 2
},
"writtenOn": "2016-11-15T16:26:54Z",
"side": 1,
"message": "Let\u0027s come up with a different name for this that starts with a verb - like \"is_up\" or something",
"revId": "e68b83054f9892161aba92917117a3b28beb2c63",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a77a97e_ab9a8f12",
"filename": "oaktreemodel/network.proto",
"patchSetId": 2
},
"lineNbr": 28,
"author": {
"id": 2
},
"writtenOn": "2016-11-15T16:26:54Z",
"side": 1,
"message": "should trim tenant_id",
"revId": "e68b83054f9892161aba92917117a3b28beb2c63",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a77a97e_4be65bb5",
"filename": "oaktreemodel/network.proto",
"patchSetId": 2
},
"lineNbr": 33,
"author": {
"id": 2
},
"writtenOn": "2016-11-15T16:26:54Z",
"side": 1,
"message": "Similar - is_shared ...",
"revId": "e68b83054f9892161aba92917117a3b28beb2c63",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a77a97e_6be317a4",
"filename": "oaktreemodel/network.proto",
"patchSetId": 2
},
"lineNbr": 39,
"author": {
"id": 2
},
"writtenOn": "2016-11-15T16:26:54Z",
"side": 1,
"message": "is_dhcp_enabled ?",
"revId": "e68b83054f9892161aba92917117a3b28beb2c63",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a77a97e_6bfa3744",
"filename": "oaktreemodel/network.proto",
"patchSetId": 2
},
"lineNbr": 42,
"author": {
"id": 2
},
"writtenOn": "2016-11-15T16:26:54Z",
"side": 1,
"message": "Should trip tenant_id - looking to the future",
"revId": "e68b83054f9892161aba92917117a3b28beb2c63",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}