x
/
omni
Code Issues Proposed changes

Update patch set 10 

Patch Set 10: Code-Review-1

(2 comments)

Patch-set: 10
This commit is contained in:
Gerrit User 25687 2019-06-19 08:59:41 +00:00 committed by Gerrit Code Review
parent fce1a2a73f
commit 377cfecd8b
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
d05c20bb60c0443bc6fa167cfc525d5701408e5b Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "9fb8cfa7_deaad3d0",
"filename": "neutron/neutron/plugins/ml2/drivers/aws/mechanism_aws.py",
"patchSetId": 10
},
"lineNbr": 225,
"author": {
"id": 25687
},
"writtenOn": "2019-06-19T08:59:41Z",
"side": 1,
"message": "Can you catch specific exception ? Maybe endpoint not found.",
"revId": "d05c20bb60c0443bc6fa167cfc525d5701408e5b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_fea317ff",
"filename": "nova/virt/ec2/config.py",
"patchSetId": 10
},
"lineNbr": 49,
"author": {
"id": 25687
},
"writtenOn": "2019-06-19T08:59:41Z",
"side": 1,
"message": "Why do we need these options? Can you work without registering them ?",
"revId": "d05c20bb60c0443bc6fa167cfc525d5701408e5b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}