x
/
ooi
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 25061 <25061@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 25061 2017-08-11 08:50:19 +00:00 committed by Gerrit Code Review
parent d3fd28ff2b
commit 610e172f92
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
d5ab0ba7d22f1feb436fd318c452cf18f7adcb0c
View File

@ -16,6 +16,24 @@
"revId": "d5ab0ba7d22f1feb436fd318c452cf18f7adcb0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f436f4f_55e78e41",
"filename": "ooi/api/helpers_neutron.py",
"patchSetId": 4
},
"lineNbr": 304,
"author": {
"id": 25061
},
"writtenOn": "2017-08-11T08:50:19Z",
"side": 1,
"message": "I see your point. Error is a bit too much for something that is unavailable by design. For the same reason I thing there\u0027s no need to let the user know that something got filtered.\nIn the other hand, I think it could be useful to the sysadmin to see that some subnets are being filtered.\nSo I can simply make the log entry a WARN.\nRegarding the Public Network distinction maybe it make no sense after all because the subnet ID and path end up in the log anyway.\nSo if you all agree I\u0027ll follow Enol\u0027s input and convert it to a warning in the log without any special case for the Public subnet.",
"parentUuid": "9f436f4f_7b93a6fb",
"revId": "d5ab0ba7d22f1feb436fd318c452cf18f7adcb0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}