589 lines
17 KiB
Plaintext
589 lines
17 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_14621aaf",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 16,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "Well, it\u0027s partially implemented ;-)",
|
|
"range": {
|
|
"startLine": 16,
|
|
"startChar": 0,
|
|
"endLine": 16,
|
|
"endChar": 49
|
|
},
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_16099494",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 16,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "I modified this sentence.",
|
|
"parentUuid": "bf659307_14621aaf",
|
|
"range": {
|
|
"startLine": 16,
|
|
"startChar": 0,
|
|
"endLine": 16,
|
|
"endChar": 49
|
|
},
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_cff08f00",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 27,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "Also worth mentioning the architecture diagram:\n\nhttps://aspiers.github.io/openstack-day-israel-2017-compute-ha/#/nova-host-alerter",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_96fcc470",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 27,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "I added this link.",
|
|
"parentUuid": "bf659307_cff08f00",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_546bb283",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "Please mention this one too, it\u0027s more relevant:\n\nhttps://github.com/openstack/openstack-resource-agents-specs/blob/master/specs/newton/approved/newton-instance-ha-host-monitoring-spec.rst",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_b6f7888b",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "I added this link.",
|
|
"parentUuid": "bf659307_546bb283",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_ef86b313",
|
|
"filename": "ocf/masakari_driver.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 168,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "As noted in nova-host-alerter, I think we need this driver to handle multiple hosts at once. So maybe it could do something like:\n\n hosts \u003d sys.stdin.read().splitlines()\n masakari_driver \u003d MasakariDriver()\n for host in hosts:\n masakari_driver.send_notification(host)",
|
|
"range": {
|
|
"startLine": 167,
|
|
"startChar": 0,
|
|
"endLine": 168,
|
|
"endChar": 39
|
|
},
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_53aabe18",
|
|
"filename": "ocf/masakari_driver.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 168,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bf659307_ef86b313",
|
|
"range": {
|
|
"startLine": 167,
|
|
"startChar": 0,
|
|
"endLine": 168,
|
|
"endChar": 39
|
|
},
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_74fd96af",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 5,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "I think it should be possible to get rid of this from the review, based on the suggestions I make below.",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_33c4eaf4",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 5,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Removed.",
|
|
"parentUuid": "bf659307_74fd96af",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_7416f6f3",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "Just write \"Currently only masakari is supported\".",
|
|
"range": {
|
|
"startLine": 29,
|
|
"startChar": 32,
|
|
"endLine": 29,
|
|
"endChar": 79
|
|
},
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_4bf1c26a",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bf659307_7416f6f3",
|
|
"range": {
|
|
"startLine": 29,
|
|
"startChar": 32,
|
|
"endLine": 29,
|
|
"endChar": 79
|
|
},
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_f4168655",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 58,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "This should not call the monitor code, because then \u0027start\u0027 would actually invoke the driver code even before it\u0027s officially started. Better to copy NovaEvacuate\u0027s approach here:\n\nhttps://git.openstack.org/cgit/openstack/openstack-resource-agents/tree/ocf/NovaEvacuate?id\u003d42bb0c53e3c21550bc37bc63e0f0b1f59a2be000#n163",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_8b2b5a93",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 58,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bf659307_f4168655",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_4f1a3f6f",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 70,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "This should not call the monitor code, because then \u0027stop\u0027 would actually invoke the driver code as part of shutdown, and we need \u0027stop\u0027 to be quick to avoid it exceeding the stop timeout which would cause fencing. Better to copy NovaEvacuate\u0027s approach here:\n\nhttps://git.openstack.org/cgit/openstack/openstack-resource-agents/tree/ocf/NovaEvacuate?id\u003d42bb0c53e3c21550bc37bc63e0f0b1f59a2be000#n158",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_6b2046ad",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 70,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bf659307_4f1a3f6f",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_74a6f655",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 86,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "Let\u0027s call this nova_host_alerter_monitor, because the \u0027status\u0027 action is deprecated.",
|
|
"range": {
|
|
"startLine": 86,
|
|
"startChar": 0,
|
|
"endLine": 86,
|
|
"endChar": 24
|
|
},
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_6e05b410",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 86,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bf659307_74a6f655",
|
|
"range": {
|
|
"startLine": 86,
|
|
"startChar": 0,
|
|
"endLine": 86,
|
|
"endChar": 24
|
|
},
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_34bf1eb1",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 93,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "This needs to check the attributes in Pacemaker\u0027s attrd, via attrd_updater. Here is how we do it in the old architecture:\n\nhttps://git.openstack.org/cgit/openstack/openstack-resource-agents/tree/ocf/NovaEvacuate?id\u003d42bb0c53e3c21550bc37bc63e0f0b1f59a2be000#n254\n\nFrom this you can get a list of *all* nodes for which we need to notify masakari.",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_f3a0b244",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 93,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bf659307_34bf1eb1",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_0f0767cc",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 102,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "As per above, I think we should send all hosts to a single invocation of $MASAKARI_DRIVER. Maybe it would be cleaner to send them via stdin rather than as arguments?",
|
|
"range": {
|
|
"startLine": 101,
|
|
"startChar": 0,
|
|
"endLine": 102,
|
|
"endChar": 52
|
|
},
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_938b76c1",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 102,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bf659307_0f0767cc",
|
|
"range": {
|
|
"startLine": 101,
|
|
"startChar": 0,
|
|
"endLine": 102,
|
|
"endChar": 52
|
|
},
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_94e86ae2",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 111,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "I think you can remove this one until we support it.",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_ce3c00ca",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 111,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Removed.",
|
|
"parentUuid": "bf659307_94e86ae2",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_74c4b65f",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 115,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "This one should result in an error, e.g.\n\n ocf_log err \"Driver type \u0027$OCF_RESKEY_driver\u0027 is not supported.\"\n return $OCF_ERR_CONFIGURED",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_0e5438fd",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 115,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bf659307_74c4b65f",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_747b56bd",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 131,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "\u0027status\u0027 is deprecated so we don\u0027t actually need it.",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_ce41603b",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 131,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bf659307_747b56bd",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_b4f80e7b",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 136,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2018-03-29T14:35:57Z",
|
|
"side": 1,
|
|
"message": "Let\u0027s call this nova_host_alerter_monitor, because the \u0027status\u0027 action is deprecated.",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bf659307_2e59fc33",
|
|
"filename": "ocf/nova-host-alerter",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 136,
|
|
"author": {
|
|
"id": 23226
|
|
},
|
|
"writtenOn": "2018-04-02T04:09:46Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "bf659307_b4f80e7b",
|
|
"revId": "c0d921672339e85231ecbc749149c72858f0c4bb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |