From b1c78d696a4ec483c1fbc60f624635bb7608ed96 Mon Sep 17 00:00:00 2001
From: Javier Pena <jpena@redhat.com>
Date: Thu, 26 Apr 2018 17:10:34 +0200
Subject: [PATCH] Fix rabbitmq configuration

We can move to the current master repo for puppet-rabbitmq, since
this is what we are testing in RDO. This requires a few changes:

- Update the URL used in the Puppetfile, and set the branch to 'master'.
- Remove old workarounds in amqp.pp
- Set loopback_users properly, based on what is requested by [1].

[1] - https://github.com/voxpupuli/puppet-rabbitmq/commit/0ada399b330fbc84a1a1179ad0e827e0735e1912

Change-Id: I9262836eb05a47bfe78ea0ac6d1c04199f29f527
---
 Puppetfile                                          |  4 ++--
 .../puppet/modules/packstack/manifests/amqp.pp      | 13 ++-----------
 2 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/Puppetfile b/Puppetfile
index 7344df564..a39d86508 100755
--- a/Puppetfile
+++ b/Puppetfile
@@ -129,8 +129,8 @@ mod 'nssdb',
   :ref => 'master'
 
 mod 'rabbitmq',
-  :git => 'https://github.com/puppetlabs/puppetlabs-rabbitmq',
-  :ref => '5.6.0'
+  :git => 'https://github.com/voxpupuli/puppet-rabbitmq',
+  :ref => 'master'
 
 mod 'redis',
   :git => 'https://github.com/arioch/puppet-redis',
diff --git a/packstack/puppet/modules/packstack/manifests/amqp.pp b/packstack/puppet/modules/packstack/manifests/amqp.pp
index 90429af58..ad3389230 100644
--- a/packstack/puppet/modules/packstack/manifests/amqp.pp
+++ b/packstack/puppet/modules/packstack/manifests/amqp.pp
@@ -28,11 +28,11 @@ define enable_rabbitmq {
       package_provider         => 'yum',
       repos_ensure             => false,
       admin_enable             => false,
+      loopback_users           => [],
       # FIXME: it's ugly to not to require client certs
       ssl_fail_if_no_peer_cert => true,
       config_variables         => {
      'tcp_listen_options' => '[binary,{packet, raw},{reuseaddr, true},{backlog, 128},{nodelay, true},{exit_on_close, false},{keepalive, true}]',
-     'loopback_users'     => '[]',
       },
     }
   } else {
@@ -44,21 +44,12 @@ define enable_rabbitmq {
       package_provider => 'yum',
       repos_ensure     => false,
       admin_enable     => false,
+      loopback_users   => [],
       config_variables => {
      'tcp_listen_options' => '[binary,{packet, raw},{reuseaddr, true},{backlog, 128},{nodelay, true},{exit_on_close, false},{keepalive, true}]',
-     'loopback_users'     => '[]',
       },
     }
   }
-
-  # TO-DO: remove this workaround as soon as this is fixed in puppetlabs-rabbitmq module
-  #        https://github.com/puppetlabs/puppetlabs-rabbitmq/pull/454
-  File <| path == '/etc/rabbitmq/rabbitmq.config' |> {
-    ensure  => present,
-    owner   => 'rabbitmq',
-    group   => 'rabbitmq',
-    mode    => '0640',
-  }
 }
 
 class packstack::amqp ()