Update patch set 2
Patch Set 2: Code-Review-1 (17 comments) nice work! i added some comments Patch-set: 2 Label: Code-Review=-1
This commit is contained in:
Gerrit User 21872
Gerrit Code Review
parent
05d42987ed
commit
add571d6d3
|
|
@ -0,0 +1,371 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_29b5cdcf",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 8,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "First part of this sentence doesn\u0027t read well; might be better if we just list the required plugins under a requirements header?",
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_69e6e5e9",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 36,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "s/config the/configure/",
|
||||
"range": {
|
||||
"startLine": 36,
|
||||
"startChar": 30,
|
||||
"endLine": 36,
|
||||
"endChar": 40
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_6934254a",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 37,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "s/identify/identifies/",
|
||||
"range": {
|
||||
"startLine": 37,
|
||||
"startChar": 44,
|
||||
"endLine": 37,
|
||||
"endChar": 52
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_497da1e6",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 38,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "s/need/needs/",
|
||||
"range": {
|
||||
"startLine": 38,
|
||||
"startChar": 49,
|
||||
"endLine": 38,
|
||||
"endChar": 53
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_29306d07",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 38,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "maybe rephrase to notification based publisher?",
|
||||
"range": {
|
||||
"startLine": 38,
|
||||
"startChar": 22,
|
||||
"endLine": 38,
|
||||
"endChar": 48
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_a9253d0b",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 38,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "delete this word",
|
||||
"range": {
|
||||
"startLine": 38,
|
||||
"startChar": 14,
|
||||
"endLine": 38,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_29178d55",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 59,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "add comma after \"On each API request\"",
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_ac39cbda",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 81,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "i think you mean triggered upon **objectstore.http.request** event(s)",
|
||||
"range": {
|
||||
"startLine": 81,
|
||||
"startChar": 30,
|
||||
"endLine": 81,
|
||||
"endChar": 63
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_2c731bb6",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 96,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "s/But/However,/",
|
||||
"range": {
|
||||
"startLine": 96,
|
||||
"startChar": 0,
|
||||
"endLine": 96,
|
||||
"endChar": 3
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_4c784f90",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 96,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "delete",
|
||||
"range": {
|
||||
"startLine": 96,
|
||||
"startChar": 35,
|
||||
"endLine": 96,
|
||||
"endChar": 36
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_6ca43308",
|
||||
"filename": "examples/openstack-alarms/swift-notifications.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 101,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "add comma after distribution",
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_8cf7a7f4",
|
||||
"filename": "examples/python-picassomiddleware/LICENSE",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 189,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "Copyright 2017 Iron.io",
|
||||
"range": {
|
||||
"startLine": 189,
|
||||
"startChar": 3,
|
||||
"endLine": 189,
|
||||
"endChar": 45
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_ec6bc383",
|
||||
"filename": "examples/python-picassomiddleware/README.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 1,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "only real concern here is the use of serverless instead of FaaS. i see it\u0027s used in the code as well...",
|
||||
"range": {
|
||||
"startLine": 1,
|
||||
"startChar": 31,
|
||||
"endLine": 1,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_4c092fdd",
|
||||
"filename": "examples/python-picassomiddleware/README.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 38,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "add comma after Swift",
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_ecf023cc",
|
||||
"filename": "examples/python-picassomiddleware/README.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 43,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "sorry, i don\u0027t think i follow. can you rephrase this sentence?",
|
||||
"range": {
|
||||
"startLine": 43,
|
||||
"startChar": 0,
|
||||
"endLine": 43,
|
||||
"endChar": 148
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_0cd8171d",
|
||||
"filename": "examples/python-picassomiddleware/functions/middleware.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 32,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "I think interchanging \"serverless\" and \"functions\" and \"FaaS\" may just lead to confusion, so we should be mindful about how we are communicating. \n\nAlso, logging \"Serverless\" doesn\u0027t tell us what OpenStack service is being logged. I think it would be best to place \"Picasso\" in the log messages instead.",
|
||||
"range": {
|
||||
"startLine": 32,
|
||||
"startChar": 50,
|
||||
"endLine": 32,
|
||||
"endChar": 70
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa31d9ce_6c34334a",
|
||||
"filename": "examples/python-picassomiddleware/setup.cfg",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 3,
|
||||
"author": {
|
||||
"id": 21872
|
||||
},
|
||||
"writtenOn": "2017-02-16T21:36:38Z",
|
||||
"side": 1,
|
||||
"message": "should be \"Picasso\", or \"Picasso (Functions-as-a-Service)\"?",
|
||||
"range": {
|
||||
"startLine": 3,
|
||||
"startChar": 50,
|
||||
"endLine": 3,
|
||||
"endChar": 72
|
||||
},
|
||||
"revId": "3d838b46fb323f1cf4596fa20ce3bfe2db9870e0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue