x
/
python-group-based-policy-client
Code Issues Proposed changes

Add the application_policy_group to the purge list 

1. also corrected the help text for the APG.
2. also clean up Neutron resources while doing the pruge as now
gbpclient inherits from neutronclient.

Change-Id: I1469ee3c51295eac7a670d105398b384db23be70
This commit is contained in:
Kent Wu 2017-03-16 11:34:59 -07:00
parent 3899fd7523
commit 0a14dc61bb
4 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gbpclient/gbp/v2_0/groupbasedpolicy.py
View File

@ -727,7 +727,8 @@ class CreateApplicationPolicyGroup(neutronV20.CreateCommand):
help=_('Description of the Application Policy Group'))
parser.add_argument(
'name', metavar='NAME',
help=_('Name of L3 policy to create (required argument)'))
help=_('Name of the Application Policy Group to create '
'(required argument)'))
n_utils.add_boolean_argument(
parser, '--shared', dest='shared',
help=_('Enable or disable resource sharing, default is False'))

7
gbpclient/gbp/v2_0/purge.py
View File

@ -87,7 +87,8 @@ class Purge(n_purge.Purge):
'policy_rule', 'policy_classifier',
'policy_action', 'network_service_policy',
'servicechain_instance', 'servicechain_spec',
'servicechain_node', 'service_profile']
'servicechain_node', 'service_profile',
'application_policy_group']
deleted = {}
failed = {}
self.total_resources = 0
@ -99,8 +100,8 @@ class Purge(n_purge.Purge):
resources)
print('\n%s' % self._build_message(deleted, failed, failures))
# TODO(Kent): clean up Neutron resources also
# super(Purge, self).take_action(parsed_args)
# clean up Neutron resources also
super(Purge, self).take_action(parsed_args)
class PurgeAPI(Purge):

3
gbpclient/tests/unit/test_cli20_purge.py
View File

@ -24,4 +24,5 @@ class CLITestV20Purge(test_cli20_purge.CLITestV20Purge):
'policy_classifier', 'policy_action',
'network_service_policy',
'servicechain_instance', 'servicechain_spec',
'servicechain_node', 'service_profile']
'servicechain_node', 'service_profile',
'application_policy_group']

2
gbpclient/v2_0/client.py
View File

@ -93,7 +93,7 @@ class APIParamsCall(object):
return with_params
class Client(clientV2_0.ClientBase):
class Client(clientV2_0.Client):
"""Client for the GBP API.
:param string username: Username for authentication. (optional)