x
/
stacktach-quince
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(3 comments)

A few minor questions on exception handling.

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 236 2015-03-12 15:39:35 +00:00 committed by Gerrit Code Review
parent 16eb7f7cab
commit 83a8f17c58
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
9158c0b83d89333e52c59a429c761edde3b7a1a9 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "9a80dd14_774eeac2",
"filename": "quince/v1_impl.py",
"patchSetId": 1
},
"lineNbr": 81,
"author": {
"id": 236
},
"writtenOn": "2015-03-12T15:39:35Z",
"side": 1,
"message": "MInor question: get_stream_by_id() *can* raise a NoSuchStreamError on a bogus stream_id (such as if it\u0027s already deleted). This should probably result in quincy returning an HTTP 404. Are we handling that anywhere?",
"revId": "9158c0b83d89333e52c59a429c761edde3b7a1a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a80dd14_d7ca3619",
"filename": "quince/v1_impl.py",
"patchSetId": 1
},
"lineNbr": 86,
"author": {
"id": 236
},
"writtenOn": "2015-03-12T15:39:35Z",
"side": 1,
"message": "Same as above.",
"revId": "9158c0b83d89333e52c59a429c761edde3b7a1a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a80dd14_d74dd69a",
"filename": "quince/v1_impl.py",
"patchSetId": 1
},
"lineNbr": 99,
"author": {
"id": 236
},
"writtenOn": "2015-03-12T15:39:35Z",
"side": 1,
"message": "Similar to the streams, get_event_by_message_id() can raise a NoSuchEventError on a nonexistant message_id. Also should be a 404.\n\nAlso, I noted get_stream() returns a list of 1 item, but get_event() just returns the event, which is probably preferrable. Is there a reason for the inconsistancy?",
"revId": "9158c0b83d89333e52c59a429c761edde3b7a1a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}