x
/
tuskar
Code Issues Proposed changes

Fix the unit tests with wrong usage of mock 

Replace assert_called_once() with self.assertEqual(1, <...>.call_count).

Change-Id: Ied357c86ba7d62c419d01a75b099a6c5de479d6e
Closes-Bug: 1473369
This commit is contained in:
Sergey Vilgelm 2015-07-26 16:33:43 +00:00
parent 64926ca8e0
commit e8eac7e562
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tuskar/tests/api/controllers/v1/test_overcloud.py
View File

@ -58,7 +58,7 @@ class OvercloudTests(base.TestCase):
self.assertEqual(result[0]['attributes']['password'], '******')
self.assertEqual(result[0]['attributes']['AdminPassword'], '******')
mock_db_get.assert_called_once()
self.assertEqual(1, mock_db_get.call_count)
@mock.patch('tuskar.db.sqlalchemy.api.'
'Connection.get_overcloud_by_id')

2
tuskar/tests/api/controllers/v1/test_overcloud_roles.py
View File

@ -48,7 +48,7 @@ class OvercloudRolesTests(base.TestCase):
self.assertEqual(1, len(result))
self.assertEqual(result[0]['name'], 'foo')
mock_db_get.assert_called_once()
self.assertEqual(1, mock_db_get.call_count)
@mock.patch('tuskar.db.sqlalchemy.api.'
'Connection.get_overcloud_role_by_id')

6
tuskar/tests/api/controllers/v2/test_plans.py
View File

@ -47,7 +47,7 @@ class PlansTests(base.TestCase):
result = response.json
# Verify
mock_list.assert_called_once()
self.assertEqual(1, mock_list.call_count)
self.assertEqual(response.status_int, 200)
self.assertTrue(isinstance(result, list))
self.assertEqual(2, len(result))
@ -64,7 +64,7 @@ class PlansTests(base.TestCase):
result = response.json
# Verify
mock_list.assert_called_once()
self.assertEqual(1, mock_list.call_count)
self.assertEqual(response.status_int, 200)
self.assertTrue(isinstance(result, list))
self.assertEqual(0, len(result))
@ -239,7 +239,7 @@ class PlansTests(base.TestCase):
result = response.json
# Verify
mock_set.assert_called_once()
self.assertEqual(1, mock_set.call_count)
self.assertEqual(mock_set.call_args[0][0], 'qwerty12345')
self.assertEqual(mock_set.call_args[0][1][0].name, 'foo')
self.assertEqual(mock_set.call_args[0][1][0].value, 'bar')