x
/
vmware-nsx
Code Issues Proposed changes

suppress W503,E731,E266,E402 hacking checks 

A recent change in pep/pycodingchecks introduced new warnings as part of
the pep8 target that causes pep8 to fail now.

This patch adds W503,E731,E266,E402 to our ignore hacking checks,
and also fix other small pep8 warnings.

Also see: https://review.openstack.org/#/c/560065/

Change-Id: Ibb76343eb7b2c10fa693432dedd3670fcf150905
This commit is contained in:
Boden R 2018-04-10 11:36:19 -06:00 committed by Adit Sarfaty
parent 4f0831e0ca
commit b942090318
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tox.ini
View File

@ -100,7 +100,8 @@ commands = sphinx-build -b html doc/source doc/build/html
# TODO(dougwig) -- uncomment this to test for remaining linkages
# N530 direct neutron imports not allowed
# N531 translations hints
ignore = E125,E126,E128,E129,E265,H305,H307,H404,H405,H904,N530,N531
# TODO(boden): check/address ,W503,E731,E266,E402
ignore = E125,E126,E128,E129,E265,H305,H307,H404,H405,H904,N530,N531,W503,E731,E266,E402
show-source = true
builtins = _
exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build,.ropeproject

6
vmware_nsx/tests/unit/nsx_v/test_plugin.py
View File

@ -3735,8 +3735,10 @@ class TestExclusiveRouterTestCase(L3NatTest, L3NatTestCaseBase,
# change address scope of the first subnetpool
with self.address_scope(name='as2') as addr_scope2,\
mock.patch.object(edge_utils, 'update_nat_rules') as update_nat,\
mock.patch.object(edge_utils, 'update_firewall') as update_fw:
mock.patch.object(
edge_utils, 'update_nat_rules') as update_nat,\
mock.patch.object(
edge_utils, 'update_firewall') as update_fw:
as2_id = addr_scope2['address_scope']['id']
data = {'subnetpool': {