diff --git a/.pylintrc b/.pylintrc index b310ea0231..0e682dc790 100644 --- a/.pylintrc +++ b/.pylintrc @@ -41,6 +41,7 @@ disable= super-init-not-called, super-on-old-class, unpacking-non-sequence, + unspecified-encoding, unused-argument, unused-import, unused-variable, diff --git a/vmware_nsx/common/config.py b/vmware_nsx/common/config.py index b5779181db..9914dec5db 100644 --- a/vmware_nsx/common/config.py +++ b/vmware_nsx/common/config.py @@ -1041,7 +1041,7 @@ register_nsxp_azs(cfg.CONF, cfg.CONF.nsx_p.availability_zones) def _get_nsx_az_opts(az, opts): - az_info = dict() + az_info = {} group = 'az:%s' % az if group not in cfg.CONF: raise nsx_exc.NsxInvalidConfiguration( diff --git a/vmware_nsx/db/extended_security_group.py b/vmware_nsx/db/extended_security_group.py index 78861e952e..80c4bf51e5 100644 --- a/vmware_nsx/db/extended_security_group.py +++ b/vmware_nsx/db/extended_security_group.py @@ -91,7 +91,7 @@ class ExtendedSecurityGroupPropertiesMixin(object): 'is_default': default_sg, } - self._registry_notify(resources.SECURITY_GROUP, events.BEFORE_CREATE, + self._registry_publish(resources.SECURITY_GROUP, events.BEFORE_CREATE, exc_cls=ext_sg.SecurityGroupConflict, payload=events.DBEventPayload( context, metadata={'is_default': default_sg}, diff --git a/vmware_nsx/db/migration/alembic_migrations/env.py b/vmware_nsx/db/migration/alembic_migrations/env.py index ecd2bd0e7d..2cf790de47 100644 --- a/vmware_nsx/db/migration/alembic_migrations/env.py +++ b/vmware_nsx/db/migration/alembic_migrations/env.py @@ -72,7 +72,7 @@ def run_migrations_offline(): """ set_mysql_engine() - kwargs = dict() + kwargs = {} if neutron_config.database.connection: kwargs['url'] = neutron_config.database.connection else: diff --git a/vmware_nsx/extensions/lsn.py b/vmware_nsx/extensions/lsn.py index 1ec13b231e..82276b913c 100644 --- a/vmware_nsx/extensions/lsn.py +++ b/vmware_nsx/extensions/lsn.py @@ -64,7 +64,7 @@ class Lsn(api_extensions.ExtensionDescriptor): plugin = directory.get_plugin() resource_name = ALIAS collection_name = resource_name.replace('_', '-') + "s" - params = RESOURCE_ATTRIBUTE_MAP.get(COLLECTION_NAME, dict()) + params = RESOURCE_ATTRIBUTE_MAP.get(COLLECTION_NAME, {}) controller = base.create_resource(collection_name, resource_name, plugin, params, allow_bulk=False) diff --git a/vmware_nsx/shell/admin/plugins/common/utils.py b/vmware_nsx/shell/admin/plugins/common/utils.py index 5c91e65119..465dfa6954 100644 --- a/vmware_nsx/shell/admin/plugins/common/utils.py +++ b/vmware_nsx/shell/admin/plugins/common/utils.py @@ -47,7 +47,7 @@ def output_header(func): def parse_multi_keyval_opt(opt_list): """Converts a MutliStrOpt to a key-value dict""" - result = dict() + result = {} opt_list = opt_list if opt_list else [] for opt_value in opt_list: try: