From ce9120192b2cb04dd65d9d6d37a24cc455ce1e54 Mon Sep 17 00:00:00 2001 From: Tobias Henkel Date: Fri, 6 Jul 2018 19:34:58 +0200 Subject: [PATCH] Cleanup test_over_quota The test_over_quota has some debug lines that should be removed. Also make the copy of the nodeset more intuitive. Change-Id: I9a168bc1446e3bb479cace68ed932401ebcdd2bf --- nodepool/driver/__init__.py | 2 +- nodepool/tests/test_launcher.py | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/nodepool/driver/__init__.py b/nodepool/driver/__init__.py index 5ae55c83e..179b34b58 100644 --- a/nodepool/driver/__init__.py +++ b/nodepool/driver/__init__.py @@ -655,7 +655,7 @@ class NodeRequestHandler(NodeRequestHandlerNotifications, # Launches are complete, so populate ready_nodes and failed_nodes. aborted_nodes = [] - for node in self.nodeset[:]: + for node in self.nodeset.copy(): if node.state == zk.READY: self.ready_nodes.append(node) elif node.state == zk.ABORTED: diff --git a/nodepool/tests/test_launcher.py b/nodepool/tests/test_launcher.py index 87f2732d3..94a28e460 100644 --- a/nodepool/tests/test_launcher.py +++ b/nodepool/tests/test_launcher.py @@ -306,9 +306,7 @@ class TestLauncher(tests.DBTestCase): pool_worker = pool.getPoolWorkers('fake-provider') while not pool_worker[0].paused_handler: - # self.log.debug("tick") time.sleep(0.1) - self.log.debug("finished waiting") # The handler is paused now and the request should be in state PENDING req2 = self.waitForNodeRequest(req2, zk.PENDING)