Update patch set 2
Patch Set 2: Code-Review-1 (1 comment) Patch-set: 2 Reviewer: Gerrit User 4162 <4162@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
184f8d206e
commit
4b40db7202
|
@ -0,0 +1,27 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df87a7cf_3a76d171",
|
||||
"filename": "playbooks/base/pre.yaml",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 4,
|
||||
"author": {
|
||||
"id": 4162
|
||||
},
|
||||
"writtenOn": "2017-12-11T22:32:46Z",
|
||||
"side": 1,
|
||||
"message": "This is already done in prepare-workspace by default:\n http://git.openstack.org/cgit/openstack-infra/zuul-jobs/tree/roles/prepare-workspace/tasks/main.yaml#n2\n\nIf we want to keep this here, then we\u0027ll need to stop doing it in prepare-workspace.\n\nMyself, I\u0027m leaning towards removing of start-zuul-console here.",
|
||||
"range": {
|
||||
"startLine": 4,
|
||||
"startChar": 0,
|
||||
"endLine": 4,
|
||||
"endChar": 24
|
||||
},
|
||||
"revId": "b73370fb65c322bcb1728869910d73e2f93f52ac",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue