zuul
/
zuul-base-jobs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 1 <1@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 1 2020-04-09 15:56:25 +00:00 committed by Gerrit Code Review
parent 7817f925c3
commit 4c1555ee11
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"key": {
"uuid": "df33271e_d9a6c5c1",
"filename": "playbooks/base/post.yaml",
"patchSetId": 2
},
"lineNbr": 5,
"author": {
"id": 1
},
"writtenOn": "2020-04-09T15:56:25Z",
"side": 1,
"message": "I thought we wanted this to work in all connections?",
"revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df33271e_54b660db",
@ -34,6 +51,23 @@
"revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df33271e_39a8918a",
"filename": "playbooks/base/pre.yaml",
"patchSetId": 2
},
"lineNbr": 18,
"author": {
"id": 1
},
"writtenOn": "2020-04-09T15:56:25Z",
"side": 1,
"message": "Shouldn\u0027t we always start-zuul-console?",
"revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}