zuul
/
zuul-base-jobs
Code Issues Proposed changes

Update patch set 8 

Patch Set 8:

(4 comments)

Thanks for the review Tobias

Patch-set: 8
Reviewer: Gerrit User 9311 <9311@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 9311 2019-01-17 06:05:00 +00:00 committed by Gerrit Code Review
parent bfc4a3448a
commit a068c855f6
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
665f7d9468cfed0f32dffdd191be7aec909cf81e
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfdaf3ff_bde0fafb",
"filename": "playbooks/openshift/pre.yaml",
"patchSetId": 8
},
"lineNbr": 0,
"author": {
"id": 9311
},
"writtenOn": "2019-01-17T06:05:00Z",
"side": 1,
"message": "Not sure what would be the role interface though...",
"parentUuid": "dfd5e7cf_63cf73b0",
"revId": "665f7d9468cfed0f32dffdd191be7aec909cf81e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfd5e7cf_83d2975b",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfdaf3ff_dd9b7ec6",
"filename": "playbooks/openshift/unprivileged-machine.yaml",
"patchSetId": 8
},
"lineNbr": 9,
"author": {
"id": 9311
},
"writtenOn": "2019-01-17T06:05:00Z",
"side": 1,
"message": "Ok, https://review.openstack.org/631402",
"parentUuid": "dfd5e7cf_83d2975b",
"revId": "665f7d9468cfed0f32dffdd191be7aec909cf81e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfd5e7cf_a3d55b45",
@ -51,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfdaf3ff_3dfe4aae",
"filename": "zuul.yaml",
"patchSetId": 8
},
"lineNbr": 31,
"author": {
"id": 9311
},
"writtenOn": "2019-01-17T06:05:00Z",
"side": 1,
"message": "The design goal is to have a ready-to-use job that builds and deploys a project so that the run phase can test command directly in the resulting pod. Changing the base_image to another builder name would let you use the same job for any type of project.\n\nAgreed it\u0027s a bit limited at the moment, but we could enhance it using variable, e.g. enable multiple replicaset. Another idea would be to look for openshift spec file in the project source and apply them directly.",
"parentUuid": "dfd5e7cf_a3d55b45",
"revId": "665f7d9468cfed0f32dffdd191be7aec909cf81e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfd5e7cf_43ccafbb",
@ -67,6 +121,24 @@
"revId": "665f7d9468cfed0f32dffdd191be7aec909cf81e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfdaf3ff_5d222e54",
"filename": "zuul.yaml",
"patchSetId": 8
},
"lineNbr": 58,
"author": {
"id": 9311
},
"writtenOn": "2019-01-17T06:05:00Z",
"side": 1,
"message": "Oh good point. I don\u0027t meant those jobs to be example, but rather ready-to-use batteries to leverage openshift environment.",
"parentUuid": "dfd5e7cf_43ccafbb",
"revId": "665f7d9468cfed0f32dffdd191be7aec909cf81e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}