Update patch set 6

Patch Set 6: Code-Review-1 (7 comments) Patch-set: 6 Reviewer: Gerrit User 6547 <6547@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
2018-07-30 11:17:13 +00:00 · 2018-07-30 11:17:13 +00:00 · e795e40ae1
parent 6485dd434b
commit e795e40ae1
1 changed files with 135 additions and 0 deletions
--- a/135
+++ b/135
@ -0,0 +1,135 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "5f7c97a3_9288716c",
+        "filename": "README.rst",
+        "patchSetId": 6
+      },
+      "lineNbr": 11,
+      "author": {
+        "id": 6547
+      },
+      "writtenOn": "2018-07-30T11:17:13Z",
+      "side": 1,
+      "message": "Assuming",
+      "range": {
+        "startLine": 11,
+        "startChar": 0,
+        "endLine": 11,
+        "endChar": 8
+      },
+      "revId": "f1777f297b8393e0f5718570f2b6b5240cb41985",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_f26be582",
+        "filename": "README.rst",
+        "patchSetId": 6
+      },
+      "lineNbr": 12,
+      "author": {
+        "id": 6547
+      },
+      "writtenOn": "2018-07-30T11:17:13Z",
+      "side": 1,
+      "message": "This needs more explanation. Lines 4-5 speak about a generic base job - and then you introduce something else here.\n\nI suggest to update lines 4-5 as well - and give more information here.\n\nWhat about:\n\nTo use containers in an OpenShift cluster, you can use one of the base openshift jobs in this repo. You need to configure nodepool to handle container and then can configure jobs.\n\nAs an example, the following is a working nodepool configuration:",
+      "revId": "f1777f297b8393e0f5718570f2b6b5240cb41985",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_b2856d55",
+        "filename": "README.rst",
+        "patchSetId": 6
+      },
+      "lineNbr": 33,
+      "author": {
+        "id": 6547
+      },
+      "writtenOn": "2018-07-30T11:17:13Z",
+      "side": 1,
+      "message": "... add to the project\u0027s zuul.yaml configuration file:",
+      "range": {
+        "startLine": 33,
+        "startChar": 0,
+        "endLine": 33,
+        "endChar": 66
+      },
+      "revId": "f1777f297b8393e0f5718570f2b6b5240cb41985",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_72e91517",
+        "filename": "README.rst",
+        "patchSetId": 6
+      },
+      "lineNbr": 48,
+      "author": {
+        "id": 6547
+      },
+      "writtenOn": "2018-07-30T11:17:13Z",
+      "side": 1,
+      "message": "New paragraph: and create the playbook file `playbooks..`:",
+      "revId": "f1777f297b8393e0f5718570f2b6b5240cb41985",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_12ea210c",
+        "filename": "README.rst",
+        "patchSetId": 6
+      },
+      "lineNbr": 56,
+      "author": {
+        "id": 6547
+      },
+      "writtenOn": "2018-07-30T11:17:13Z",
+      "side": 1,
+      "message": "Like above \"add to the project\u0027s zuul.yaml configuration file\":",
+      "revId": "f1777f297b8393e0f5718570f2b6b5240cb41985",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_92ddd16f",
+        "filename": "README.rst",
+        "patchSetId": 6
+      },
+      "lineNbr": 73,
+      "author": {
+        "id": 6547
+      },
+      "writtenOn": "2018-07-30T11:17:13Z",
+      "side": 1,
+      "message": "Like above, new paragraph:\n\nCreate the playbook file...",
+      "revId": "f1777f297b8393e0f5718570f2b6b5240cb41985",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_b2cecd55",
+        "filename": "zuul.yaml",
+        "patchSetId": 6
+      },
+      "lineNbr": 53,
+      "author": {
+        "id": 6547
+      },
+      "writtenOn": "2018-07-30T11:17:13Z",
+      "side": 1,
+      "message": "Nit: Let\u0027s add final \".\" as in the ones above",
+      "revId": "f1777f297b8393e0f5718570f2b6b5240cb41985",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}