zuul-base-jobs/cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f

{
  "comments": [
    {
      "key": {
        "uuid": "df33271e_d9a6c5c1",
        "filename": "playbooks/base/post.yaml",
        "patchSetId": 2
      },
      "lineNbr": 5,
      "author": {
        "id": 1
      },
      "writtenOn": "2020-04-09T15:56:25Z",
      "side": 1,
      "message": "I thought we wanted this to work in all connections?",
      "revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "df33271e_3996d13f",
        "filename": "playbooks/base/post.yaml",
        "patchSetId": 2
      },
      "lineNbr": 5,
      "author": {
        "id": 1
      },
      "writtenOn": "2020-04-09T15:59:00Z",
      "side": 1,
      "message": "Oh, Tristan created fetch-output-openshift.  So how about we put another conditional here for that?",
      "revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "df33271e_39aff17d",
        "filename": "playbooks/base/post.yaml",
        "patchSetId": 2
      },
      "lineNbr": 5,
      "author": {
        "id": 9311
      },
      "writtenOn": "2020-04-09T15:59:51Z",
      "side": 1,
      "message": "Yes that is missing indeed.",
      "parentUuid": "df33271e_3996d13f",
      "revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "df33271e_d9bd25b8",
        "filename": "playbooks/base/post.yaml",
        "patchSetId": 2
      },
      "lineNbr": 5,
      "author": {
        "id": 2
      },
      "writtenOn": "2020-04-09T16:02:02Z",
      "side": 1,
      "message": "++",
      "parentUuid": "df33271e_3996d13f",
      "revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "df33271e_54b660db",
        "filename": "playbooks/base/pre.yaml",
        "patchSetId": 2
      },
      "lineNbr": 13,
      "author": {
        "id": 4146
      },
      "writtenOn": "2020-04-06T16:54:00Z",
      "side": 1,
      "message": "Should this check if the connection is ssh instead of checking that it isn\u0027t kubectl? We also support windows connectivity which doesn\u0027t use ssh.",
      "revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "df33271e_f4e334a3",
        "filename": "playbooks/base/pre.yaml",
        "patchSetId": 2
      },
      "lineNbr": 13,
      "author": {
        "id": 9311
      },
      "writtenOn": "2020-04-06T17:03:54Z",
      "side": 1,
      "message": "perhaps, though i don\u0027t know how to test that effectively. This condition should be backward compatible with existing users.",
      "parentUuid": "df33271e_54b660db",
      "revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "df33271e_f92bc9e7",
        "filename": "playbooks/base/pre.yaml",
        "patchSetId": 2
      },
      "lineNbr": 13,
      "author": {
        "id": 2
      },
      "writtenOn": "2020-04-09T16:02:02Z",
      "side": 1,
      "message": "I agree with both of you - I thnk there is probably something we should do better for windows folks, but we\u0027re not doing it now. This should be backwards compat to what we\u0027re currently doing.",
      "parentUuid": "df33271e_f4e334a3",
      "revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "df33271e_39a8918a",
        "filename": "playbooks/base/pre.yaml",
        "patchSetId": 2
      },
      "lineNbr": 18,
      "author": {
        "id": 1
      },
      "writtenOn": "2020-04-09T15:56:25Z",
      "side": 1,
      "message": "Shouldn\u0027t we always start-zuul-console?",
      "revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "df33271e_59a0f590",
        "filename": "playbooks/base/pre.yaml",
        "patchSetId": 2
      },
      "lineNbr": 18,
      "author": {
        "id": 9311
      },
      "writtenOn": "2020-04-09T15:59:51Z",
      "side": 1,
      "message": "IIRC this is performed by the prepare-workspace",
      "parentUuid": "df33271e_39a8918a",
      "revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "df33271e_d9308559",
        "filename": "playbooks/base/pre.yaml",
        "patchSetId": 2
      },
      "lineNbr": 18,
      "author": {
        "id": 2
      },
      "writtenOn": "2020-04-09T16:02:02Z",
      "side": 1,
      "message": "++",
      "parentUuid": "df33271e_39a8918a",
      "revId": "cebe5f01e7dd4fe40c90b45cdc48d69d69eb7a6f",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}