From 0c906b36145f3bf84f6eab610bc11c549696403e Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Mon, 12 Mar 2018 14:22:23 -0700 Subject: [PATCH] Fix error in test_jobs_executed Due to the recent change in statsd metric names, the hostname that test_jobs_executed looks for may need to be updated. In the gate, the hostname is not an FQDN, but if it is, it will need this substitution. Change-Id: I28b64404c9a3569323264274ff5b0fa932aebe78 --- tests/unit/test_scheduler.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/unit/test_scheduler.py b/tests/unit/test_scheduler.py index 8fc9c17e3a..4331959f70 100755 --- a/tests/unit/test_scheduler.py +++ b/tests/unit/test_scheduler.py @@ -115,7 +115,8 @@ class TestScheduler(ZuulTestCase): self.assertReportedStat( 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.' 'org_project.master.total_changes', value='1|c') - exec_key = 'zuul.executor.%s' % self.executor_server.hostname + exec_key = 'zuul.executor.%s' % self.executor_server.hostname.replace( + '.', '_') self.assertReportedStat(exec_key + '.builds', value='1|c') self.assertReportedStat('zuul.nodepool.requested', value='1|c') self.assertReportedStat('zuul.nodepool.requested.label.label1',