From 20b2c01e9939e7168ca6de63ae69ae42dbc71bb2 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Wed, 10 Oct 2018 15:03:04 -0700 Subject: [PATCH] Remove disable-recommends in quick-start test This test is trying to test a user process on a typical VM/workstation so make sure that apt behaves in the default manner and installs recommended packages (such as docker itself). Change-Id: I62b1367f9d4311deedf16176fa3f97cf0b3a74f1 --- playbooks/quick-start/run.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/playbooks/quick-start/run.yaml b/playbooks/quick-start/run.yaml index aff6f35e16..c0d9de4dcc 100644 --- a/playbooks/quick-start/run.yaml +++ b/playbooks/quick-start/run.yaml @@ -2,10 +2,17 @@ vars: workspace: /tmp/quickstart-test tasks: + # Our test images disable installation of recommended packages; + # re-enable that (the default) to make this test more closely + # resemble what a user will encounter. + - name: Remove disable-recommends + file: + name: /etc/apt/apt.conf.d/95disable-recommends + state: absent + become: true - name: Install docker-compose and git-review package: name: - - docker.io # See note [1] - docker-compose - git-review state: present @@ -43,7 +50,3 @@ cmd: | {{ ssh_agent.stdout }} ssh-agent -k - -# [1]: docker.io is a recommended package and is therefore typically -# automatically installed, however our test images disable this -# behavior, so it is listed explicitly here.