zuul
/
zuul
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 1 \u003c1@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4146\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 4146 \u003c4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4146\u003e replied on the change"}
This commit is contained in:
Gerrit User 4146 2024-05-14 23:54:28 +00:00 committed by Gerrit Code Review
parent 51f6adca8e
commit 53b338ba18
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
1b7602aa77ff18ecb5cc963c15e86de30386b1e7
View File

@ -175,6 +175,24 @@
"revId": "1b7602aa77ff18ecb5cc963c15e86de30386b1e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "dfcfe4a3_a9717980",
"filename": "zuul/model.py",
"patchSetId": 3
},
"lineNbr": 6136,
"author": {
"id": 4146
},
"writtenOn": "2024-05-14T23:54:28Z",
"side": 1,
"message": "Ack this was sort of a minor concern and I think the meaning can be inferred from the text anyway. Worst case you can look at the code for more context.",
"parentUuid": "3d739e72_f6baf4fc",
"revId": "1b7602aa77ff18ecb5cc963c15e86de30386b1e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -314,6 +332,24 @@
"parentUuid": "655b0b4f_f08cf56d",
"revId": "1b7602aa77ff18ecb5cc963c15e86de30386b1e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "06eba6fe_2ef9cd57",
"filename": "zuul/web/__init__.py",
"patchSetId": 3
},
"lineNbr": 2037,
"author": {
"id": 4146
},
"writtenOn": "2024-05-14T23:54:28Z",
"side": 1,
"message": "The updated patchset modified the buildsets() api call but not this buildset() api call. Should we update both?",
"parentUuid": "bfdf28e5_3494359a",
"revId": "1b7602aa77ff18ecb5cc963c15e86de30386b1e7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}