From d2f67f497d7f643e9553991b7007d8e626930952 Mon Sep 17 00:00:00 2001 From: Tobias Henkel Date: Thu, 21 Jun 2018 19:30:33 +0000 Subject: [PATCH] Fix race in tox-remote test_command In test_command we create the file /tmp/console-None.log. We now have two hosts in that test that are mapped to the same host. This could lead to failures [1] during creation of that file. Fix that by adding run_once. [1] Test failure 2018-06-20 14:12:00.349980 | TASK [Create unwritable /tmp/console-None.log] 2018-06-20 14:12:00.727614 | controller | changed 2018-06-20 14:12:00.734316 | compute1 | ERROR 2018-06-20 14:12:00.734612 | compute1 | { 2018-06-20 14:12:00.734734 | compute1 | "gid": 1000, 2018-06-20 14:12:00.734828 | compute1 | "group": "zuul", 2018-06-20 14:12:00.734910 | compute1 | "mode": "0444", 2018-06-20 14:12:00.734987 | compute1 | "msg": "Error, could not touch target: [Errno 13] Permission denied: \'/tmp/console-None.log\'", 2018-06-20 14:12:00.735063 | compute1 | "owner": "zuul", 2018-06-20 14:12:00.735137 | compute1 | "path": "/tmp/console-None.log", 2018-06-20 14:12:00.735211 | compute1 | "size": 0, 2018-06-20 14:12:00.735284 | compute1 | "state": "file", 2018-06-20 14:12:00.735357 | compute1 | "uid": 1000 2018-06-20 14:12:00.735430 | compute1 | } Change-Id: Ib1d48fea57447131d7018e6a2772f289a668299a --- .../remote-zuul-stream/git/org_project/playbooks/command.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/fixtures/config/remote-zuul-stream/git/org_project/playbooks/command.yaml b/tests/fixtures/config/remote-zuul-stream/git/org_project/playbooks/command.yaml index dec392381d..dc7fcb6825 100644 --- a/tests/fixtures/config/remote-zuul-stream/git/org_project/playbooks/command.yaml +++ b/tests/fixtures/config/remote-zuul-stream/git/org_project/playbooks/command.yaml @@ -9,6 +9,7 @@ path: /tmp/console-None.log state: touch mode: 0444 + run_once: True - name: Start zuul_console daemon zuul_console: