zuul
/
zuul
Code Issues Proposed changes

Make sure we always log the exit line 

If there's an exception, we might not write the final lines to the log.
Put those in a finally block.

Change-Id: I0a294af3874c53543176a7bd9c4b89253717b83c
This commit is contained in:
Monty Taylor 2017-06-13 15:10:28 -05:00
parent 2c414c1ca2
commit d635d2a31c
No known key found for this signature in database
GPG Key ID: 7BAE94BC7141A594
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
zuul/ansible/library/command.py
View File

@ -356,6 +356,10 @@ def zuul_run_command(self, args, zuul_log_id, check_rc=False, close_fds=True, ex
if umask:
old_umask = os.umask(umask)
t = None
fail_json_kwargs = None
ret = None
try:
if self._debug:
self.log('Executing: ' + clean_args)
@ -394,11 +398,27 @@ def zuul_run_command(self, args, zuul_log_id, check_rc=False, close_fds=True, ex
except (OSError, IOError):
e = get_exception()
self.log("Error Executing CMD:%s Exception:%s" % (clean_args, to_native(e)))
self.fail_json(rc=e.errno, msg=to_native(e), cmd=clean_args)
fail_json_kwargs=dict(rc=e.errno, msg=str(e), cmd=clean_args)
except Exception:
e = get_exception()
self.log("Error Executing CMD:%s Exception:%s" % (clean_args, to_native(traceback.format_exc())))
self.fail_json(rc=257, msg=to_native(e), exception=traceback.format_exc(), cmd=clean_args)
fail_json_kwargs = dict(rc=257, msg=str(e), exception=traceback.format_exc(), cmd=clean_args)
finally:
if t:
with Console(zuul_log_id) as console:
if t.isAlive():
console.addLine("[Zuul] standard output/error still open "
"after child exited")
if not ret and fail_json_kwargs:
ret = fail_json_kwargs['rc']
elif not ret and not fail_json_kwargs:
ret = -1
console.addLine("[Zuul] Task exit code: %s\n" % ret)
if ret == -1 and not fail_json_kwargs:
self.fail_json(rc=ret, msg="Something went horribly wrong during task execution")
if fail_json_kwargs:
self.fail_json(**fail_json_kwargs)
# Restore env settings
for key, val in old_env_vals.items():