openstack
/
pbr
Code Issues Proposed changes

Fix author and changelog skipping. 

Same problem as the other one.

Change-Id: I6d63b6d969756bca6b7df9ef9ee78e12ca1b052e
Reviewed-on: https://review.openstack.org/30538
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
This commit is contained in:
Monty Taylor 2013-05-25 14:36:57 +02:00 committed by Jenkins
parent 304196c101
commit f675e5fb4a
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pbr/packaging.py
View File

@ -145,7 +145,7 @@ def _get_git_directory():
def get_boolean_option(option_dict, option_name, env_name):
return ((option_name in option_dict
and option_dict[option_name].lower() in TRUE_VALUES) or
and option_dict[option_name][1].lower() in TRUE_VALUES) or
str(os.getenv(env_name)).lower() in TRUE_VALUES)

3
pbr/tests/test_setup.py
View File

@ -127,7 +127,8 @@ class SkipFileWrites(tests.BaseTestCase):
self.filename = os.path.join(self.temp_path, self.filename)
self.option_dict = dict()
if self.option_key is not None:
self.option_dict[self.option_key] = self.option_value
self.option_dict[self.option_key] = ('setup.cfg',
self.option_value)
self.useFixture(
fixtures.EnvironmentVariable(self.env_key, self.env_value))