Using a single test run orchestrator makes it easier to maintain
the project, especially as pytest is actively maintained.
Change-Id: I5c843984bc0a1b9264e744373e6a3fd9d43e99cd
Switches queries testing to use of pytest which provides the following:
- test generator for each query (parametrize)
- ability to test a single query test
- generate html report with test results, making easier to investigate
failures.
- parallel executions
- minor bugfix which prevented running queries from running with py38
as the config parser requires only strings (None being invalid).
Change-Id: I982c694a5160a9ecfd117d177d30b911cfe53425
Apparently under linux pip can become fully blocked due to keyring
presence. That is a known open bug, so we apply the workaround until
it is fixed.
Change-Id: I30a5ec1b04b57a5604cb3caa3bc56ea2476e89ba
- Dropping py27 as is out of support
- Enable py38 testing, already default python on several distros.
- removes six as a dependency as is no longer needed for pure py3
Change-Id: I1e825073abc6cd55aa2fdc363358f2701152c57b
- Upgraded hacking(flake8)
- Added more modern tox linters environment (pep8 alias)
- Temporary added skips for broken newer rules
- Fixed few basic rule violations
- Moved flake8 config to setup.cfg (tox.ini is not recommended)
Change-Id: I75b3ce5d2ce965a9dc5bdfaa49b2aacd8f0195ad
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I62e9b6aff712accd3856a3ae0caa0c847aaecbbb
Closes-Bug: #1801657
This change converts the repo to the new PTI workflow
and modernises the docs by using the OpenStack docs theme.
Change-Id: I5a3706c7cf40ee0c3405131b89f956bf75cae244
There is some weirdness around the pbr testr command and in some
environments the coverage command doesn't include all the options.
To remedy this lets just use the test command which is what works
everywhere.
Change-Id: I1d1bcb3e17363e4079c865cc1e94256ce2255bed
When executing scripts with a "python" prefix like tox does here, the
directory containing the script is put on the Python path. This is a
problem if any module or file in that directory has the same name as a
Python standard library module, as it means that the module in
elastic-recheck will "shadow" the module in the standard library and be
imported in preference to the stdlib version.
In the case of elastic-recheck, this means that tox -e run does not
actually work: the elastic_recheck.cmd module shadows the stdlib cmd
module, and a long import chain ends up importing pdb which imports the
stdlib cmd module. This ends up causing an AttributeError, leaving the
run environment useless.
However, the script that the run environment wants to invoke is already
installed into the virtual environment by pbr, which means we can simply
invoke it directly and virtualenv will ensure that the correct binary is
invoked.
Change-Id: I6dec4ae58ab10f44c92f94ddb531e6d278d01451
Signed-off-by: Cory Benfield <cory.benfield@hpe.com>
Add an other-requirements.txt file containing a cross-platform list
of dependencies needed for running included tox-based tests. Also
include a tox environment for convenience calling the bindep[*]
utility to list any missing system requirements.
This change is self-testing.
For other-requirements.txt see also
http://docs.openstack.org/infra/manual/drivers.html#package-requirements
[*] http://docs.openstack.org/infra/bindep/
Change-Id: I3fa07db6a01a045308fbdc517a695f7be2e88014
Remove unused tox environments and add used ones.
We don't gate on py26 or pypy support and are not planning on it any
time soon, so remove those environments from the default list.
Remove functional env since we don't use it and add queries environment
since we are now running it as non voting.
Change-Id: I573987ee49dbed7d520137044bbcef267e8761a7
Previously test_queries, tested for:
* check if the query has hits
* check if the launchpad bug is open
This wasn't a good test to gate on because hits can go away and bugs can
be closed, so this test can stop working without any code changes,
making it a bad gating test.
Split out getting launchpad test working to a separate patch, still a
few more issues to sort out there.
Change-Id: Ic362d89a0ed34bb14864237e4bc5975befc36497
It's apparent that elastic-recheck is quite a ways from Py3K
support, and developers are not expected to run the py33 tox env.
Rather than add more envs for later Python interpreter versions
which will be equally broken, just remove it for now.
Change-Id: I6fb62f55d39eb812c585c19f9e16c482775f793a
This commit fixes the coverage job in tox. It relies on pbr to
actually make the coverage calls before and after running the tests.
However, by default pbr assumes the project name in setup.cfg is the
same as the directory containing the source. However that isn't the
case here. This commits corrects this by using the flag to pretend
that package name is the same as the source dir. This change also
sets the correct regex for testr to run the unit tests only, which is
what is needed for the coverage job. The pbr requirement is also
updated to be >=0.8.1 because this is the min version required to
use the option exploited by this patch.
Change-Id: Icea30575538571fe842632901e994be3ac0bbc80
* tox.ini: The LANG, LANGUAGE and LC_ALL environment overrides were
introduced originally during the testr migration in an attempt to be
conservative about the possibility that locale settings in the
calling environment could cause consistency problems for test runs.
In actuality, this should be unnecessary and any place where it does
cause issues ought to be considered an actual bug. Also, having
these in the configuration actively causes older pip to have
problems with non-ASCII content in some package metadata files under
Python 3, so drop it now.
Change-Id: If453210cb0f9117a445a464e18b842a82cace866
Closes-Bug: #1277495
This commit adds the --noirc option to the tox job for running the
bot for testing. This way when testing the bot it won't leave irc
messages.
Change-Id: I923072261bc03022a3c133e1aa425e528be77770
this makes the bot based on argparse, and provides a tox job that
makes running the bot in test mode a little more sane. It also
provides for a new '-n' nocomment item so you can run the bot
and not be worried that it will report to gerrit with findings.
Change-Id: If9d6a7e72dd8d9338f2dd3283cf9a761488122de
The current tox would fail with an error because it didn't want
to install the lazr.authentication package because it's external.
This change makes it so that tox will allow the install of the
required lazr.authentication package.
Change-Id: I9b766df31f7662e36180188cc699e8665f5d317f
In the land of random cleanups, let more of the whitespace rules
back in. Also explicitly exclude E125 because of the overreach,
and leave E123 excluded because it creates some kind of odd
artifacts in the current code (possibly clean it up later).
Tox.ini adjusted with comments about the fact that what we are
ignoring is there for a reason.
Change-Id: I5636cb646d7898df71b715aa0e32a68ce279ee80
elastic_recheck started off life ignoring the 80 column boundary.
We should stop that, as it's bad form. Also, I do multi column
emacs and it blows my column widths.
So fix all the E501 issues and start enforcing the rules in tox
Change-Id: Ib0a1d48d085d9b21fbc1bab75e93e9cc40d36988
This commit breaks up the tests into 2 subdirectories, unit and functional.
Functional tests use the network in some way and may require either a
queries file or a functional config. Unit tests do not have these
requirements. In addition the default tox job is changed to only run the
unit tests. The functional tests are give a separate tox job.
Change-Id: I4bdc7f1098bfb7fa16dd869b2e54b3154848c3e1
Make repo support 'tox -epep8' as we want this to be the first gating
check.
Don't make any actual code changes, just change setup and add files.
Further work is needed to re-organize the code, but that can be in a
separate patch.
Sorin Sbarnea