Commit Graph

2948 Commits

Author SHA1 Message Date
Ian Wienand 234ed85a92 Retire repo
Change-Id: I7d68f82c75cbc4dc7e843198593846e19cf88f14
2022-04-05 13:20:00 +10:00
Andreas Jaeger ac5628a6ff Remove .gitreview
This .gitreview is broken. Instead of fixing it, remove it since
the main purpose of the repo in opendev is importing the upstream repo
and not working on it.

Change-Id: I6ca8fade72c37d7e4335ae9ab60b4158fefceb75
2020-01-13 16:39:28 +01:00
OpenDev Sysadmins 3d8ae56286 OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.
2019-04-19 19:25:39 +00:00
James E. Blair e707725ee6 Hack out some CLA bits.
Replace the link to the settings/agreements page in the git push error
message with a hardcoded link to the OpenStack wiki.

Remove the form widgets that permit agreeing to a CLA.

Change-Id: Ibfbb8bec245ae494a49cb905925fd2c4f34686f2
2012-01-06 11:21:08 -08:00
Monty Taylor cdcd5193d4 Add gitreview file.
Change-Id: Ie024b2dd5480852ecf7c23a6789eb148f54a48d1
2011-12-21 07:05:33 +00:00
Jenkins e79f3475c5 Merge "Add owner username to gerrit query command." 2011-11-08 23:48:34 +00:00
James E. Blair bf47a9665f Add owner username to gerrit query command.
Change-Id: Iec0a2adfdf6c4a2dd9a94dc327b68f836b59da59
2011-11-08 14:53:03 -08:00
Monty Taylor d0fa8866d4 Reject commit subjects over 50 characters.
Add a test in receive commits for commit message first lines of over 50
characters and a boolean config option to enable checking for it.

Change-Id: I557d1ff72e6df97b991b05c36483c13873b706fb
2011-11-08 14:26:40 -08:00
James E. Blair 1e35b2096f Add OpenID SSO support. Configuring OPENID_SSO in gerrit.config
will allow the admin to specify an SSO entry point URL so that
users clicking on "Sign In" are sent directly to that URL.
2011-07-22 23:27:06 +00:00
Shawn O. Pearce bd1ee1ad12 Draft release notes for 2.2.1
Change-Id: I93643c4d0aec8a9b194f8606839673ba0dbf1e3f
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-06-07 13:46:57 -07:00
Shawn O. Pearce 080a51f4e6 Merge branch 'stable'
* stable:
  Fix ChangeDetailFactory's invocation of PatchSetDetailFactory
  Release notes for 2.1.7.1
  Fix API breakage on ChangeDetailService
  Do not reset Patch History selection on navigation to next file diff
  Resolve Project Owners when checking access right on any ref

Conflicts:
	gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java
	gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java

Change-Id: I6e956625cb4648df35035b9be2d32e6e431fb8f3
2011-06-07 13:44:39 -07:00
Shawn O. Pearce 1118daf779 Correct usage of @Nullable annotation in EventFactory
Change-Id: Iaf110a8499eb5c1169a3f70a56ec6ca6d299b6c1
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-06-07 13:43:52 -07:00
Magnus Vigerlöf f86b214184 Replace the shell code that tries to emulate git config with an error.
Replace the code with an error message that git has to be
in the PATH instead of trying to parse gerrit.conf with
shell code. The shell code do not remove whitespaces as
it should and this will give stranger errors when looking
for java later in the script (all platforms/shells).
This code doesn't seem to have been used anyway.

Change-Id: Ideba5b950a97c0e77839cbddd4616ef737470da2
2011-06-07 22:17:34 +02:00
Shawn O. Pearce 019d2c4dfb Fix ChangeDetailFactory's invocation of PatchSetDetailFactory
I flipped the order of the arguments, but did not correctly
update all callers.

Change-Id: Iae14ec35374342f53bc353082db35cb8750a750a
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-06-07 11:47:22 -07:00
Shawn O. Pearce 0a939db5bf Release notes for 2.1.7.1
Change-Id: If75ca735e5bea95f136cd7dc0ebf73de582af37f
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-06-07 10:12:44 -07:00
Shawn O. Pearce e313242c05 Fix API breakage on ChangeDetailService
The Mylyn Reviews project pointed out Gerrit changed the API
signature of a JSON method they use remotely. Fix the API back to the
original signature, and define a new method with the extra arguments.

Change-Id: I51cbbdd64bdb72a666a6b5266db3b93494b75182
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-06-07 10:10:39 -07:00
Shawn Pearce 045b76c6d6 Merge "Implement multiple branches in ls-project" 2011-06-07 09:50:09 -07:00
Shawn O. Pearce 99071dd232 Rename "-- All Projects --" to "All-Projects"
The name "-- All Projects --" is awkard to work with on the command
line due to starting with leading hypens, and containing spaces.

In prior versions of Gerrit Code Review this did not really matter,
the project was stored only in the database and did not need to be
accessed by command line tools. Now that the access controls are
in Git and are stored in a Git repository, this directory exists
and needs to be managed.

Bug: issue 994
Change-Id: I19b0967c6cf2720dcd2fd72a354e3566def15fdb
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-06-07 09:42:13 -07:00
Shawn O. Pearce d12c47672c Fix administration of projects with no access controls
If a project has no access controls listed in its project.config,
nobody was able to add new sections in the web UI.  Ensure that
users are at least able to create new sections if they have owner
power on any reference, which may be inherited down from parent
projects or be implied because of their site administrator status.

Bug: issue 1000
Change-Id: I19bab2a75fe3248275fef9fd87ed86cfa580845a
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-06-07 08:13:30 -07:00
Shawn Pearce 9fb03c8bc9 Merge "Add ExpandAllComments checkbox in PatchScreen" 2011-06-07 08:04:45 -07:00
Martin Fick 066c71219d Add error messages for abandon and restore when in bad state
The abandon and restore routines can fail if the change
is in the wrong state (abandoned already, or open still).
These failure lead to internal NPEs.  Instead, create a
new exception and give a reason for the failure to the user.

Change-Id: Id7861d75e535c439c12329f7e891797c5b1f6eca
2011-06-07 08:13:12 -06:00
Shawn Pearce 40d2020668 Merge "Resolve Project Owners when checking access right on any ref" into stable 2011-06-07 07:09:00 -07:00
Shawn O. Pearce 824d1e6c80 Merge "Only create source archives for packages that need one" 2011-06-06 10:51:51 -07:00
Edwin Kempin 3cd9de924e Fix search by codereview status
Change-Id: I864dc6eca27ed9bca7004ef9bc5b5536737cc6ec
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Bug: issue 1001
2011-06-06 10:47:25 +02:00
Raviteja Sunkara 3ec87fa1be Add ExpandAllComments checkbox in PatchScreen
Change-Id: I2bc786285940655d17c498ec6abbe8dfe8e5e974
2011-06-06 12:13:41 +05:30
Edwin Kempin c82e9e98b6 Do not reset Patch History selection on navigation to next file diff
When the user views a file diff and then changes in the Patch History
the selection of side A (left side), then this selection is lost when
the user navigates to the previous or next file diff. The selection of
side A is always reset to the patch set that is selected as 'Old
Version History' on the ChangeScreen (the base for comparing patch
sets).

This change ensures that the selection in the Patch History is kept
when the user navigates to the previous or next file diff.

Bug: issue 999
Change-Id: I19cafedd8a11683dca4a24fbebbcacf63425fe62
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
2011-06-03 13:35:12 +02:00
Edwin Kempin 1199891854 Resolve Project Owners when checking access right on any ref
A project is visible to a user when the user has Read Access on any
ref of the project. This check whether an access right is granted on
any ref is not taking the access rights granted to the
'Project Owners' group into account. As a result a user does not see
a project if he is project owner and Read Access is only granted to
the 'Project Owners' group. This change ensures that the
'Project Owners' group is properly resolved in this case.

Bug: issue 997
Change-Id: I27cd8293e5c4a01c867a4e076073bf587294e0ba
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
2011-06-03 09:12:13 +02:00
Shawn O. Pearce a52f8cd6a3 Only create source archives for packages that need one
We don't push our code to a Maven repository, so there only reason
to construct source archives is to feed source files into the GWT
compiler.  Move the source plugin onto only the packages that we
feed into the GWT code, allowing the others to skip this step.

This fixes a "bug" in a later change that adds the Prolog Cafe
translater to the build process.  Without this change first, the
Prolog Cafe translator is firing twice for every Prolog source file
that is part of our standard build.

Change-Id: Iba38aa371ce7c8950ac30dc3cf06e01b465afb5a
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-06-02 10:01:53 -07:00
Shawn O. Pearce 55e9025582 Draft 2.2.0 release notes
Change-Id: I53ba82c6347ec79686f047099de34636611507e2
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-31 10:30:57 -07:00
Shawn O. Pearce 4e67700dab Change version to 2.2-SNAPSHOT
Change-Id: I1d3e6c42bc678536162a81d2b13372659a1c3dec
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-31 10:30:57 -07:00
Shawn O. Pearce 106e5b7b00 Merge branch 'stable'
* stable:
  Update 2.1.7 release notes
  ExportReviewNotes: Default to 2 threads

Change-Id: Icc576083ec6ffa5cbbe5163ab34b8c843dc3ab66
2011-05-31 10:13:41 -07:00
Shawn O. Pearce e43d3c4669 Update 2.1.7 release notes
Change-Id: Ib2fe7ccbc1713487333e67216d5082e8e71497b8
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-31 09:53:50 -07:00
Shawn O. Pearce bf9d9ed987 ExportReviewNotes: Default to 2 threads
Not all systems have enough database connections in the connection
pool to support 2 threads per CPU. Exporting lots of changes doesn't
take that long, so 2 threads is acceptable.

Change-Id: I69bbade7f67023689ca54665833bc764d2d5503d
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-31 09:52:46 -07:00
Shawn O. Pearce b645c639fc Merge branch 'stable'
* stable:
  Escape spaces in HTTP URLs during replication
  Invert signed-in and signed-out background colors
2011-05-27 15:51:03 -07:00
Shawn O. Pearce 1f412fe330 Escape spaces in HTTP URLs during replication
If the repository name contains spaces (e.g. "-- All Projects --")
the spaces must be URL encoded using the esacpe "%20" in order to
appear in an http:// or https:// URL.

Encoding does *not* happen for ssh:// and git:// protocols as these
both pass-through the remote repository name as-is.

Change-Id: I3bb494c1bc3e21f3a9960071e9930a5ec1c8cf1a
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-27 15:48:01 -07:00
Anatol Pomazau 3739569aad Implement multiple branches in ls-project
Allow users request SHA1 of multiple branches per command:

$ ssh -p 29418 review.example.com gerrit ls-projects -b eclair -b gingerbread

In case if a branch is not visible or does not exists then stub is shown. Here is
a sample of the command output:

---------------------------------------- d8a9e45c7ec6ff97b44fdbd0b21cabdb69f5f15b foo
---------------------------------------- 87e4297f8f508e9b73863b27c25a551a4d4b5ed5 bar
a7e9587229246f6eb876795bc45a09c17b3bed51 862b2ce84f38e93a50d29510e713475f11228b28 baz
405cd3f5d7df7bae701b313dad9ce2ef797eb754 6a7eb2f0c885d03320b58afb662ee4fc14659063 hello
---------------------------------------- 782effdaeba782a656f799c9584dcc82fbfb7fa7 world
b8240b951de6c03f72278dd3d7790c2355878197 e8099cc12a3b64aa4e58b319e61f0190e27bd3ac kext

Change-Id: Ib05a6fc770ed0b70a3c180b2a41bec5e95a7117b
2011-05-24 11:14:03 -07:00
Shawn O. Pearce 9ca8ae3eca Invert signed-in and signed-out background colors
Most users work in the signed-in mode when reading source files
during review. Using the white background makes it easier to read
the text, especially with syntax coloring enabled.

Change-Id: If49aa62c0ff26971c64fd75505265c58ac859062
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-24 08:28:40 -07:00
Shawn O. Pearce 7f84ef2379 ExportReviewNotes: Fix duplicate Guice bindings
The GitRepositoryManager and @GerritPersonIdent PersonIdent are now
bound in the SchemaModule as part of the git-store topic.

Change-Id: I3935b7d699c899e419d8db0836ad5dd9e2894aff
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-23 08:44:32 -07:00
Shawn O. Pearce b7ebfe1d90 Merge "Automatically check for refs/meta/config changes" 2011-05-20 17:50:49 -07:00
Shawn O. Pearce b8e4e35949 Automatically check for refs/meta/config changes
Periodically check a project's refs/meta/config for modifications
made outside of Gerrit Code Review.  This ensures slave servers will
eventually pick up new access controls or project settings without
requiring administrators to flush the "projects" cache over SSH.

Checks are done only every cache.projects.checkFrequency period, as a
local disk check requires at least one stat() call to examine the
loose reference's last modified time. This is relatively inexpensive
for a single project request like git clone, but not feasible for
multiple project lookups like a query results page or user dashboard.

To prevent many calls to System.currentTimeMillis() a background
thread (managed by Executors.newScheduledThreadPool) is used to update
a generation flag every checkFrequency period. During a cache get the
ProjectState rechecks its refs/meta/config if the generation does not
match, and gets replaced if there were changes.

Bug: issue 962
Change-Id: I9ad4db27329968e2993b4dd142d1325446190065
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-20 17:48:38 -07:00
Shawn O. Pearce 3d1f73fff7 Fix GroupControl check for isOwner()
This check was broken when groups were changed to use UUIDs for the
effective groups set of an IdentifiedUser.  The check must pass the
new UUID type to contains() rather than the older Id type.

We cache the owner decision in case we get multiple calls are made to
this GroupControl.  This happens in the loops that invoke the canSee()
methods for each element.

Change-Id: Ifaa6adb456183267fc8030a1fcb04c283b20e941
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-20 17:06:32 -07:00
Shawn O. Pearce b352fc6c5e Merge branch 'stable'
* stable:
  Fix SLF4J StaticLoggerBinder warning
  ExportReviewNotes: Dump submitted changes to refs/notes/review

Conflicts:
	gerrit-server/src/main/java/com/google/gerrit/server/git/CreateCodeReviewNotes.java

Change-Id: I147ba04af6d8af4177dcdd94d55e8b1c7d9b10e9
2011-05-20 17:02:49 -07:00
Nasser Grainawi 79f88a11e8 Fix SLF4J StaticLoggerBinder warning
http://www.slf4j.org/codes.html#StaticLoggerBinder

Change-Id: Ic04c0f1f45ce4a454df95d741ca421b6d27a7fe9
2011-05-20 15:00:27 -07:00
Shawn O. Pearce 1b8810f411 ExportReviewNotes: Dump submitted changes to refs/notes/review
This program allows site administrators to dump their existing notes
out to the refs/notes/review branch, making the prior data available
to Git clients.

Change-Id: Iebaf1e4b2fb4620443e80d2a8f840cb30ae1e389
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-20 14:44:28 -07:00
Shawn O. Pearce 0bfcc2181c Merge branch 'stable'
* stable:
  Support different color pallete when not signed in
  Send new patchset event after its available
  Enable git:// download URLs if canonicalGitUrl set
  Fix NPE on Gerrit startup if mail.from doesn't include a name
  Add config setting to only suggest users which are in a visible group

Change-Id: I2bc9ca40e616c7f7b0c12de41f631c916439289c
2011-05-20 11:43:43 -07:00
Shawn O. Pearce a83bb1c344 Support different color pallete when not signed in
If the user is not signed in a different theme of colors can be
applied to the UI, making it more obvious that login is necessary.

Bug: issue 913
Change-Id: Id8c780042740b3b93dcee7ed84b3f9f6be06d9de
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-20 09:45:27 -07:00
Shawn O. Pearce ebe5db58f9 Merge changes I14eb9d19,I8f6d5c5a into stable
* changes:
  Send new patchset event after its available
  Enable git:// download URLs if canonicalGitUrl set
2011-05-20 08:06:26 -07:00
Shawn Pearce e647a81b1d Merge "Add config setting to only suggest users which are in a visible group" into stable 2011-05-20 07:46:45 -07:00
Shawn O. Pearce 79a9896f59 Send new patchset event after its available
gerrit stream-events sent notification of a new patch set before it
created the reference in the Git repository. This confused some CI
systems that were able to read the stream-events message and look for
the reference before the server was able to create it.

Bug: issue 755
Change-Id: I14eb9d19984701eb9afbb13e006a24057e8c3473
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-20 07:17:03 -07:00
Shawn O. Pearce 70d336d49b Enable git:// download URLs if canonicalGitUrl set
If the administrator has set gerrit.canonicalGitUrl but has left the
download.scheme variable unset to its default, assume they want to use
git:// as a type of download and enable it.

Bug: issue 966
Change-Id: I8f6d5c5a3d16821d07c61f16bce9680a7e0721e5
Signed-off-by: Shawn O. Pearce <sop@google.com>
2011-05-20 07:05:31 -07:00