The prepare-workspace-git role recently replaced the use-cached-repos
role, but its behavior is slightly different. While use-cached-repos
removed the 'origin' remote, prepare-workspace-git replaces it with a
zuul fake origin.
Release jobs used to add an 'origin' remote to enable notes fetching.
Those jobs now fail because the 'origin' remote already exists. We
fix this by resetting the URL for the 'origin' remote, instead of
adding a new one.
Change-Id: Ifa80ff02dd06a65fd60189c97438554fc4100932
To not install these on the images, create a new scripts directory to
hold them.
Create new copy-release-tools-scripts role to copy the files over,
we do not need using legacy-copy-project-config-scripts anymore since
everything is copied elsewhere.
Add the role to all playbooks that use release-tools scripts.
Change-Id: I36c458e297fec58023799f625739b341c4d403cf
All of these invocations of the bindep role are passing what amount to
the defaults. In zuul-jobs, doing bindep_dir: "{{ zuul_work_dir }}" is
important because it allows in-repo uses of those jobs to override how
they work for things like triggering from one repo but running on
another.
The publication jobs in project-config do not need that level of
flexibility, so just remove params and let defaults take over.
As a follow up, we could also add defaults for zuul_work_dir - and
honestly for bindep_dir - to the base job. That way we can always count
on them being set to a sane default value, and they're still
overrideable in a job.
Change-Id: I5bcda84aefa4726d0a904e8bc9698c21ca07f9a5
Zuul has transitioned zuul.projects to a dict that mirrors
zuul._projects. Convert users back to zuul.projects so we can remove
the underscore version in zuul.
Change-Id: Ib71241a862cf29f6e542dc1d4a2c5cd554d5d7d8
Depends-On: I3c011f72933e98ccbf8badf0e9197c8659766c51
This re-implements I430277369f9ecb2ecc0a31f795c72bba83bcecff (that had
to be reverted with commit c8628dd8f8).
The original change had a small syntax error using
"zuul.projects.values()" instead of "zuul._projects.values()". This
is corrected here.
It also had a problem with_items: zuul._projects.values() -- in
python3 this returns a view, which doesn't work with "with_items:"
... so you need to "| list".
Integration test results (for use-cached-repos at least) in
I7828f78efd1d20031cf1c34629200f265576e7a7.
Change-Id: I9d88f405f34d1c5f75ebf4f52cedfaaab20c3bda
Merge the two release scripts into one python script.
Change-Id: Ic9832b58f10b0a8a7f2f11b9200f88913706aa3d
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Rather than passing a string to the shell task and then using
shell.args.executable to choose an explicit executable, use
shell.cmd to set the actual script content so that shell.executable
can be used to choose the shell.
Change-Id: Ia24a21ce54746a486ba39c4eb7c32bc8470e32d4
The tag playbook used for the tag-releases job attempts to export a
variable containing a path relative to the user's homedir. This
works fine for tilde expansion in bash, but in vanilla sh ends up
passing a literal tilde into the consuming scripts at least some of
which do not perform their own os.path.expanduser() on the string.
Go ahead and explicitly use bash for the shell task in this playbook
to get the advance expansion it seems to assume.
Change-Id: Id10e37e5a2a32b7051c986f0541b1ed9f326e95c
This reverts commit dc06e340d5.
Troubleshooting is complete, and secure removal of the credentials
can be safely restored now.
Change-Id: I18ab248bfd32f7588c7bf041e7b98e32e1db494e
The launchpadlib credential setup used by tag-releases to comment on
LP bugs is not yet working as expected. Temporarily stop shredding
and deleting the credential file so that a manually-held node can be
inspected for deeper investigation.
Change-Id: Id4cea87320f89b2c01d94616ee00019c7f69b0e8
Instead of scripting the git configuration, use tasks in pre playbooks
for the jobs. We use different settings for tag-releases and
propose-constraint-updates.
Change-Id: Id3713d89a8b2af821de41a146954be551337cf75
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
It uses this on the remote node in order to sign the git tags.
Remove it and the ssh private key from the remote node as well.
Change-Id: I89c58194905aec383af7b4c7d970b040ca4e55bb
Depends-On: I2f13f0c4de91808ba1bbdcc0fd20a547e43d602b
Update the tag-releases job and the scripts it runs to accumulate
error exit codes and fail if there are any, but to continue to run as
many parts of the job as possible.
Change-Id: I5625e5f4b31af5d54d570581e9ef5000599fb035
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Zuul exports the projects list as a dictionary in _projects in the
depends-on. The idea is that we switch these jobs to that, and do
some testing. When ready, we switch "projects" to be the dictionary
view, and revert "_project" calls here to "project".
Change-Id: I430277369f9ecb2ecc0a31f795c72bba83bcecff
The release-tools/functions script needs common.sh but has been
relying on the calling script to source it properly. Have the
functions script source its own dependency to ensure it is always done
properly.
Change-Id: I2f1b6c32cf2f454bdc3a9841891f464da07dc788
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
The tag-releases job now needs to run bindep to install some
dependencies on the dynamic nodes used for tagging releases that are
not present in the default image.
Change-Id: I8d0affa6eb8bc7d0fe1130b9968a0f88f7e4aa96
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
That should be "its" (possessive) not "it's" (contraction).
Also, ansible/jinja is overly confused by imbalanced quote marks of
any kind (single or double), even in comment lines within shell
tasks.
Change-Id: I422f30556b6d0fff5e8f36382cfd378013456bb2
tag-releases needs to fetch notes. To avoid touching the jenkins script
too much while v2 and v3 co-exist, just add the origin remote for all
projects in the pre-playbook.
Once v3 is rolled out fully and there is breathing room, this should be
reworked along with the contents of the script to meet all of the use
cases in a more native manner.
Change-Id: I8224ec098756874d5422fdb119d72ea1509b72a3
The correct role is add-launchpad-credentials.
Change-Id: I24e0dd0a37306822e9a1738e16e1da169d7062d0
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Thierry Carrez